| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250224195059.10185-4-lkml@antheas.dev>
Date: Mon, 24 Feb 2025 20:50:59 +0100
From: Antheas Kapenekakis <lkml@...heas.dev>
To: mario.limonciello@....com,
mpearson-lenovo@...ebb.ca
Cc: ilpo.jarvinen@...ux.intel.com,
lenb@...nel.org,
linux-acpi@...r.kernel.org,
linux-kernel@...r.kernel.org,
platform-driver-x86@...r.kernel.org,
rafael@...nel.org,
hdegoede@...hat.com,
me@...egospodneti.ch,
Antheas Kapenekakis <lkml@...heas.dev>
Subject: [PATCH 3/3] ACPI: platform_profile: Do not hide options missing in
secondary handlers
In the legacy endpoint, previously, only the options common to all
handlers were exposed. This causes an issue when the primary handler
of the device has its options hidden, as it results in a performance
degradation.
Therefore, this commit introduces the concept of secondary handlers.
These are handlers that are able to accept all options and do not
partake in the process of selecting which profiles are visible.
These handlers still have a probe function which is used for their
endpoint and their endpoint works normally and will block other
options. However, when called from the legacy endpoint, all options
will be sent to them. It is the expectation that secondary handlers
will pick the closest profile they have to what was sent.
In the absence of a primary handler, the options shown in the legacy
endpoint will be the union of all options of all secondary handlers.
Signed-off-by: Antheas Kapenekakis <lkml@...heas.dev>
---
drivers/acpi/platform_profile.c | 57 ++++++++++++++++++++++++++++-----
1 file changed, 49 insertions(+), 8 deletions(-)
diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
index 2ad53cc6aae5..55e8bb6adf8e 100644
--- a/drivers/acpi/platform_profile.c
+++ b/drivers/acpi/platform_profile.c
@@ -63,17 +63,18 @@ static ssize_t _commmon_choices_show(unsigned long *choices, char *buf)
* _store_class_profile - Set the profile for a class device
* @dev: The class device
* @data: The profile to set
+ * @enforce_valid: For secondary handlers, enforce that the profile is valid
*
* Return: 0 on success, -errno on failure
*/
-static int _store_class_profile(struct device *dev, void *data)
+static int _store_class_profile(struct device *dev, void *data, bool enforce_valid)
{
struct platform_profile_handler *handler;
int *bit = (int *)data;
lockdep_assert_held(&profile_lock);
handler = to_pprof_handler(dev);
- if (!test_bit(*bit, handler->choices))
+ if ((enforce_valid || !handler->ops->secondary) && !test_bit(*bit, handler->choices))
return -EOPNOTSUPP;
return handler->ops->profile_set(dev, *bit);
@@ -204,7 +205,7 @@ static ssize_t profile_store(struct device *dev,
return -EINVAL;
scoped_cond_guard(mutex_intr, return -ERESTARTSYS, &profile_lock) {
- ret = _store_class_profile(dev, &index);
+ ret = _store_class_profile(dev, &index, true);
if (ret)
return ret;
}
@@ -243,21 +244,37 @@ static const struct class platform_profile_class = {
*
* Return: 0 on success, -errno on failure
*/
-static int _aggregate_choices(struct device *dev, void *data)
+static int _aggregate_choices(struct device *dev, void *data, bool secondary)
{
struct platform_profile_handler *handler;
unsigned long *aggregate = data;
lockdep_assert_held(&profile_lock);
handler = to_pprof_handler(dev);
+
+ if (handler->ops->secondary != secondary)
+ return 0;
+
if (test_bit(PLATFORM_PROFILE_LAST, aggregate))
bitmap_copy(aggregate, handler->choices, PLATFORM_PROFILE_LAST);
+ else if (handler->ops->secondary)
+ bitmap_or(aggregate, handler->choices, aggregate, PLATFORM_PROFILE_LAST);
else
bitmap_and(aggregate, handler->choices, aggregate, PLATFORM_PROFILE_LAST);
return 0;
}
+static int _aggregate_choices_primary(struct device *dev, void *data)
+{
+ return _aggregate_choices(dev, data, false);
+}
+
+static int _aggregate_choices_secondary(struct device *dev, void *data)
+{
+ return _aggregate_choices(dev, data, true);
+}
+
/**
* platform_profile_choices_show - Show the available profile choices for legacy sysfs interface
* @dev: The device
@@ -276,9 +293,16 @@ static ssize_t platform_profile_choices_show(struct device *dev,
set_bit(PLATFORM_PROFILE_LAST, aggregate);
scoped_cond_guard(mutex_intr, return -ERESTARTSYS, &profile_lock) {
err = class_for_each_device(&platform_profile_class, NULL,
- aggregate, _aggregate_choices);
+ aggregate, _aggregate_choices_primary);
if (err)
return err;
+
+ if (test_bit(PLATFORM_PROFILE_LAST, aggregate)) {
+ err = class_for_each_device(&platform_profile_class, NULL,
+ aggregate, _aggregate_choices_secondary);
+ if (err)
+ return err;
+ }
}
/* no profile handler registered any more */
@@ -325,7 +349,7 @@ static int _store_and_notify(struct device *dev, void *data)
enum platform_profile_option *profile = data;
int err;
- err = _store_class_profile(dev, profile);
+ err = _store_class_profile(dev, profile, false);
if (err)
return err;
return _notify_class_profile(dev, NULL);
@@ -384,9 +408,18 @@ static ssize_t platform_profile_store(struct device *dev,
set_bit(PLATFORM_PROFILE_LAST, choices);
scoped_cond_guard(mutex_intr, return -ERESTARTSYS, &profile_lock) {
ret = class_for_each_device(&platform_profile_class, NULL,
- choices, _aggregate_choices);
+ choices, _aggregate_choices_primary);
if (ret)
return ret;
+
+ if (test_bit(PLATFORM_PROFILE_LAST, choices)) {
+ ret = class_for_each_device(
+ &platform_profile_class, NULL, choices,
+ _aggregate_choices_secondary);
+ if (ret)
+ return ret;
+ }
+
if (!test_bit(i, choices))
return -EOPNOTSUPP;
@@ -470,10 +503,18 @@ int platform_profile_cycle(void)
return -EINVAL;
err = class_for_each_device(&platform_profile_class, NULL,
- choices, _aggregate_choices);
+ choices, _aggregate_choices_primary);
if (err)
return err;
+ if (test_bit(PLATFORM_PROFILE_LAST, choices)) {
+ err = class_for_each_device(
+ &platform_profile_class, NULL, choices,
+ _aggregate_choices_secondary);
+ if (err)
+ return err;
+ }
+
/* never iterate into a custom if all drivers supported it */
clear_bit(PLATFORM_PROFILE_CUSTOM, choices);
--
2.48.1
Powered by blists - more mailing lists