linux-kernel - Re: [PATCH] ceph: osd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5939f53e1f928e20d67b8e6fa06d6ce9a0b8a9ae.camel@ibm.com>
Date: Mon, 24 Feb 2025 19:55:29 +0000
From: Viacheslav Dubeyko <Slava.Dubeyko@....com>
To: "idryomov@...il.com" <idryomov@...il.com>, Xiubo Li <xiubli@...hat.com>,
        "linux@...blig.org" <linux@...blig.org>,
        "ceph-devel@...r.kernel.org"
	<ceph-devel@...r.kernel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re:  [PATCH] ceph: osd_client deadcode

On Sat, 2025-02-22 at 01:35 +0000, linux@...blig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> osd_req_op_extent_osd_data_pagelist() was added in 2013 as part of
> commit a4ce40a9a7c1 ("libceph: combine initializing and setting osd data")
> but never used.
> 
> The last use of osd_req_op_cls_request_data_pagelist() was removed in
> 2017's
> commit ecd4a68a26a2 ("rbd: switch rbd_obj_method_sync() to
> ceph_osdc_call()")
> 
> Remove them.
> 

If we don't use these methods, then it makes sense to remove it. We can take
them back in the case of real necessity in this functionality.

Reviewed-by: Viacheslav Dubeyko <Slava.Dubeyko@....com>

Thanks,
Slava.