linux-kernel - Re: [PATCH net-next v3 2/4] stmmac: loongson: Remove surplus loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1082af86-de49-40ee-bd62-80d068e869ac@lunn.ch>
Date: Mon, 24 Feb 2025 20:55:39 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Philipp Stanner <phasta@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Huacai Chen <chenhuacai@...nel.org>,
	Yanteng Si <si.yanteng@...ux.dev>,
	Yinggang Gu <guyinggang@...ngson.cn>,
	Feiyang Chen <chenfeiyang@...ngson.cn>,
	Philipp Stanner <pstanner@...hat.com>,
	Jiaxun Yang <jiaxun.yang@...goat.com>,
	Qing Zhang <zhangqing@...ngson.cn>, netdev@...r.kernel.org,
	linux-stm32@...md-mailman.stormreply.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 2/4] stmmac: loongson: Remove surplus loop

On Mon, Feb 24, 2025 at 02:53:20PM +0100, Philipp Stanner wrote:
> loongson_dwmac_probe() contains a loop which doesn't have an effect,
> because it tries to call pcim_iomap_regions() with the same parameters
> several times. The break statement at the loop's end furthermore ensures
> that the loop only runs once anyways.
> 
> Remove the surplus loop.
> 
> Signed-off-by: Philipp Stanner <phasta@...nel.org>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew