linux-kernel - Re: [PATCH v13 08/14] x86/mm: global ASID context switch & TLB flush handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0bb6a374a02995e78db49beb69e0f369480520a4.camel@surriel.com>
Date: Sun, 23 Feb 2025 20:26:17 -0500
From: Rik van Riel <riel@...riel.com>
To: kernel test robot <lkp@...el.com>, x86@...nel.org
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
 bp@...en8.de, 	peterz@...radead.org, dave.hansen@...ux.intel.com,
 zhengqi.arch@...edance.com, 	nadav.amit@...il.com, thomas.lendacky@....com,
 kernel-team@...a.com, 	linux-mm@...ck.org, akpm@...ux-foundation.org,
 jackmanb@...gle.com, 	jannh@...gle.com, mhklinux@...look.com,
 andrew.cooper3@...rix.com, 	Manali.Shukla@....com, mingo@...nel.org
Subject: Re: [PATCH v13 08/14] x86/mm: global ASID context switch & TLB
 flush handling

On Mon, 2025-02-24 at 07:08 +0800, kernel test robot wrote:
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from <command-line>:
>    arch/x86/include/asm/tlbflush.h: In function 'in_asid_transition':
> > > arch/x86/include/asm/tlbflush.h:253:43: error: 'mm_context_t' has
> > > no member named 'asid_transition'
>      253 |         return mm && READ_ONCE(mm-
> >context.asid_transition);
>          |                                           ^

Looks like this one needs to be moved under
the #ifdef, too.

Short-circuiting the build by hard-disabling
X86_FEATURE_INVLPGB, or even adding an explicit
if(!IS_ENABLED(CONFIG_X86_BROADCAST_TLB_FLUSH))
is not enough to get the compiler to short-circuit
the rest of the code in that function.

We might need an #ifdef inside destroy_context_free_global_asid
as well, no good way to move that one into a .h file without
making the global asid data structures in tlb.c visible to
the entire kernel instead of keeping them static in tlb.c

-- 
All Rights Reversed.