linux-kernel - Re: [PATCH 3/4] arm64: dts: qcom: sdm632-fairphone-fp3: Add firmware-name for adsp & wcnss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82a9d623-2033-4d7f-93b8-67007b46be79@lucaweiss.eu>
Date: Mon, 24 Feb 2025 21:43:48 +0100
From: Luca Weiss <luca@...aweiss.eu>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: qcom: sdm632-fairphone-fp3: Add
 firmware-name for adsp & wcnss

On 24-02-2025 9:27 p.m., Konrad Dybcio wrote:
> On 24.02.2025 1:17 AM, Dmitry Baryshkov wrote:
>> On Sat, Feb 22, 2025 at 02:00:49PM +0100, Luca Weiss wrote:
>>> Set the paths where the device-specific firmware can be found for this
>>> device.
>>>
>>> Fairphone 3 was shipped with secure-boot off so any testkey-signed
>>> firmware is accepted.
>>>
>>> Signed-off-by: Luca Weiss <luca@...aweiss.eu>
>>> ---
>>>   arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 7 +++++++
>>>   1 file changed, 7 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
>>> index 08ffe77d762c3a97f470efbfb5064282fe2090da..5611209dbfa41d7834af7903535ed3e05604ba63 100644
>>> --- a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
>>> +++ b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
>>> @@ -82,6 +82,8 @@ nfc@28 {
>>>   };
>>>   
>>>   &lpass {
>>> +	firmware-name = "qcom/msm8953/fairphone/fp3/adsp.mbn";
>>
>> If any firmware is okay, wouldn't it be better to use
>> "qcom/msm8953/foo.mbn" ? This way if we get any of the firmware (yeah,
>> I'm a dreamer), then FB3 can pick it up.
> 
> No, the fw may have board/wiring differences encoded inside it

Second that, while I don't have access to the AMSS sources for this 
device, I'm sure there's at least some board-specific config in these 
images, and I'd rather not boot up some ADSP or modem firmware compiled 
for some Dragonboard or equivalent.

Regards
Luca

> 
> Konrad