linux-kernel - [PATCH 2/2] bus: bt1-apb: use dev_groups to register attribute groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250224204600.3138007-2-ovidiu.panait.oss@gmail.com>
Date: Mon, 24 Feb 2025 22:46:00 +0200
From: Ovidiu Panait <ovidiu.panait.oss@...il.com>
To: linux-kernel@...r.kernel.org
Cc: fancer.lancer@...il.com,
	linux-mips@...r.kernel.org,
	tsbogend@...ha.franken.de,
	Ovidiu Panait <ovidiu.panait.oss@...il.com>
Subject: [PATCH 2/2] bus: bt1-apb: use dev_groups to register attribute groups

Instead of manually adding/removing attribute groups, set dev_groups
pointer to have the driver core do it.

Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@...il.com>
---
 drivers/bus/bt1-apb.c | 31 ++-----------------------------
 1 file changed, 2 insertions(+), 29 deletions(-)

diff --git a/drivers/bus/bt1-apb.c b/drivers/bus/bt1-apb.c
index 7463124b6dd9..ca4b6b1f896f 100644
--- a/drivers/bus/bt1-apb.c
+++ b/drivers/bus/bt1-apb.c
@@ -321,30 +321,6 @@ static struct attribute *bt1_apb_sysfs_attrs[] = {
 };
 ATTRIBUTE_GROUPS(bt1_apb_sysfs);
 
-static void bt1_apb_remove_sysfs(void *data)
-{
-	struct bt1_apb *apb = data;
-
-	device_remove_groups(apb->dev, bt1_apb_sysfs_groups);
-}
-
-static int bt1_apb_init_sysfs(struct bt1_apb *apb)
-{
-	int ret;
-
-	ret = device_add_groups(apb->dev, bt1_apb_sysfs_groups);
-	if (ret) {
-		dev_err(apb->dev, "Failed to create EHB APB sysfs nodes\n");
-		return ret;
-	}
-
-	ret = devm_add_action_or_reset(apb->dev, bt1_apb_remove_sysfs, apb);
-	if (ret)
-		dev_err(apb->dev, "Can't add APB EHB sysfs remove action\n");
-
-	return ret;
-}
-
 static int bt1_apb_probe(struct platform_device *pdev)
 {
 	struct bt1_apb *apb;
@@ -370,10 +346,6 @@ static int bt1_apb_probe(struct platform_device *pdev)
 	if (ret)
 		return ret;
 
-	ret = bt1_apb_init_sysfs(apb);
-	if (ret)
-		return ret;
-
 	return 0;
 }
 
@@ -387,7 +359,8 @@ static struct platform_driver bt1_apb_driver = {
 	.probe = bt1_apb_probe,
 	.driver = {
 		.name = "bt1-apb",
-		.of_match_table = bt1_apb_of_match
+		.of_match_table = bt1_apb_of_match,
+		.dev_groups = bt1_apb_sysfs_groups,
 	}
 };
 module_platform_driver(bt1_apb_driver);
-- 
2.48.1