linux-kernel - Re: [PATCH v5 2/6] scripts/sorttable: Have mcount rela sort use direct values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <893cd8f1-8585-4d25-bf0f-4197bf872465@app.fastmail.com>
Date: Mon, 24 Feb 2025 22:10:53 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Steven Rostedt" <rostedt@...dmis.org>, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
 bpf <bpf@...r.kernel.org>, linux-arm-kernel@...ts.infradead.org,
 linux-s390@...r.kernel.org
Cc: "Masami Hiramatsu" <mhiramat@...nel.org>,
 "Mark Rutland" <mark.rutland@....com>,
 "Mathieu Desnoyers" <mathieu.desnoyers@...icios.com>,
 "Andrew Morton" <akpm@...ux-foundation.org>,
 "Peter Zijlstra" <peterz@...radead.org>,
 "Linus Torvalds" <torvalds@...ux-foundation.org>,
 "Masahiro Yamada" <masahiroy@...nel.org>,
 "Nathan Chancellor" <nathan@...nel.org>,
 "Nicolas Schier" <nicolas@...sle.eu>,
 "Zheng Yejian" <zhengyejian1@...wei.com>,
 "Martin Kelly" <martin.kelly@...wdstrike.com>,
 "Christophe Leroy" <christophe.leroy@...roup.eu>,
 "Josh Poimboeuf" <jpoimboe@...hat.com>, "Heiko Carstens" <hca@...ux.ibm.com>,
 "Catalin Marinas" <catalin.marinas@....com>, "Will Deacon" <will@...nel.org>,
 "Vasily Gorbik" <gor@...ux.ibm.com>,
 "Alexander Gordeev" <agordeev@...ux.ibm.com>
Subject: Re: [PATCH v5 2/6] scripts/sorttable: Have mcount rela sort use direct values

On Tue, Feb 18, 2025, at 20:59, Steven Rostedt wrote:
> From: Steven Rostedt <rostedt@...dmis.org>
>
> The mcount_loc sorting for when the values are stored in the Elf_Rela
> entries uses the compare_extable() function to do the compares in the
> qsort(). That function does handle byte swapping if the machine being
> compiled for is a different endian than the host machine. But the
> sort_relocs() function sorts an array that pulled in the values from the
> Elf_Rela section and has already done the swapping.
>
> Create two new compare functions that will sort the direct values. One
> will sort 32 bit values and the other will sort the 64 bit value. One of
> these will be assigned to a compare_values function pointer and that will
> be used for sorting the Elf_Rela mcount values.
>
> Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>
> ---

This is what I get on arm64 randconfig builds using clang after your
patch:

  failed to sort mcount 'Expected 24260 mcount elements but found 0
  ': vmlinux
  Failed to sort kernel tables

I have not tried to understand what your patch does. See the attached
defconfig for a reproducer.

      Arnd
Download attachment "defconfig" of type "application/octet-stream" (25930 bytes)