| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250224161832-mutt-send-email-mst@kernel.org>
Date: Mon, 24 Feb 2025 16:18:47 -0500
From: "Michael S. Tsirkin" <mst@...hat.com>
To: Yury Norov <yury.norov@...il.com>
Cc: linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
linux-s390@...r.kernel.org, netdev@...r.kernel.org,
virtualization@...ts.linux.dev, linux-nvme@...ts.infradead.org,
linux-hyperv@...r.kernel.org, linux-pci@...r.kernel.org,
linux-scsi@...r.kernel.org, linux-crypto@...r.kernel.org,
Michael Ellerman <mpe@...erman.id.au>,
Nicholas Piggin <npiggin@...il.com>,
Christophe Leroy <christophe.leroy@...roup.eu>,
Naveen N Rao <naveen@...nel.org>,
Madhavan Srinivasan <maddy@...ux.ibm.com>,
Heiko Carstens <hca@...ux.ibm.com>,
Vasily Gorbik <gor@...ux.ibm.com>,
Alexander Gordeev <agordeev@...ux.ibm.com>,
Christian Borntraeger <borntraeger@...ux.ibm.com>,
Sven Schnelle <svens@...ux.ibm.com>,
Haren Myneni <haren@...ux.ibm.com>,
Rick Lindsley <ricklind@...ux.ibm.com>,
Nick Child <nnac123@...ux.ibm.com>,
Thomas Falcon <tlfalcon@...ux.ibm.com>,
Andrew Lunn <andrew+netdev@...n.ch>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Jason Wang <jasowang@...hat.com>,
Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
Eugenio Pérez <eperezma@...hat.com>,
Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...nel.dk>,
Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>,
"K. Y. Srinivasan" <kys@...rosoft.com>,
Haiyang Zhang <haiyangz@...rosoft.com>,
Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Krzysztof Wilczyński <kw@...ux.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
James Smart <james.smart@...adcom.com>,
Dick Kennedy <dick.kennedy@...adcom.com>,
"James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
"Martin K. Petersen" <martin.petersen@...cle.com>,
Rasmus Villemoes <linux@...musvillemoes.dk>,
Matt Wu <wuqiang.matt@...edance.com>,
Steffen Klassert <steffen.klassert@...unet.com>,
Daniel Jordan <daniel.m.jordan@...cle.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Greg Kurz <groug@...d.org>, Peter Xu <peterx@...hat.com>,
Shrikanth Hegde <sshegde@...ux.ibm.com>,
Hendrik Brueckner <brueckner@...ux.ibm.com>
Subject: Re: [PATCH v2 00/13] cpumask: cleanup cpumask_next_wrap()
implementation and usage
On Tue, Jan 28, 2025 at 11:46:29AM -0500, Yury Norov wrote:
> cpumask_next_wrap() is overly complicated, comparing to it's generic
> version find_next_bit_wrap(), not mentioning it duplicates the above.
> It roots to the times when the function was used in the implementation
> of for_each_cpu_wrap() iterator. The function has 2 additional parameters
> that were used to catch loop termination condition for the iterator.
> (Although, only one is needed.)
>
> Since 4fe49b3b97c262 ("lib/bitmap: introduce for_each_set_bit_wrap()
> macro"), for_each_cpu_wrap() is wired to corresponding generic
> wrapping bitmap iterator, and additional complexity of
> cpumask_next_wrap() is not needed anymore.
>
> All existing users call cpumask_next_wrap() in a manner that makes
> it possible to turn it to a straight and simple alias to
> find_next_bit_wrap().
>
> This series replaces historical 4-parameter cpumask_next_wrap() with a
> thin 2-parameter wrapper around find_next_bit_wrap().
>
> Where it's possible to use for_each_cpu_wrap() iterator, the code is
> switched to use it because it's always preferable to use iterators over
> open loops.
>
> This series touches various scattered subsystems and To-list for the
> whole series is quite a long. To minimize noise, I send cover-letter and
> key patches #5 and 6 to every person involved. All other patches are sent
> individually to those pointed by scripts/get_maintainers.pl.
>
> I'd like to move the series with my bitmap-for-next branch as a whole.
virtio-net changes are straight-forward, so
Acked-by: Michael S. Tsirkin <mst@...hat.com>
> v1: https://lore.kernel.org/netdev/20241228184949.31582-1-yury.norov@gmail.com/T/
> v2:
> - rebase on top of today's origin/master;
> - drop #v1-10: not needed since v6.14 @ Sagi Grinberg;
> - #2, #3: fix picking next unused CPU @ Nick Child;
> - fix typos, cleanup comments @ Bjorn Helgaas, Alexander Gordeev;
> - CC Christoph Hellwig for the whole series.
>
> Yury Norov (13):
> objpool: rework objpool_pop()
> virtio_net: simplify virtnet_set_affinity()
> ibmvnic: simplify ibmvnic_set_queue_affinity()
> powerpc/xmon: simplify xmon_batch_next_cpu()
> cpumask: deprecate cpumask_next_wrap()
> cpumask: re-introduce cpumask_next{,_and}_wrap()
> cpumask: use cpumask_next_wrap() where appropriate
> padata: switch padata_find_next() to using cpumask_next_wrap()
> s390: switch stop_machine_yield() to using cpumask_next_wrap()
> scsi: lpfc: switch lpfc_irq_rebalance() to using cpumask_next_wrap()
> scsi: lpfc: rework lpfc_next_{online,present}_cpu()
> PCI: hv: Switch hv_compose_multi_msi_req_get_cpu() to using
> cpumask_next_wrap()
> cpumask: drop cpumask_next_wrap_old()
>
> arch/powerpc/xmon/xmon.c | 6 +--
> arch/s390/kernel/processor.c | 2 +-
> drivers/net/ethernet/ibm/ibmvnic.c | 18 +++++---
> drivers/net/virtio_net.c | 12 ++---
> drivers/pci/controller/pci-hyperv.c | 3 +-
> drivers/scsi/lpfc/lpfc.h | 23 +++-------
> drivers/scsi/lpfc/lpfc_init.c | 2 +-
> include/linux/cpumask.h | 69 ++++++++++++++++++++---------
> include/linux/objpool.h | 7 ++-
> kernel/padata.c | 2 +-
> lib/cpumask.c | 37 +---------------
> 11 files changed, 81 insertions(+), 100 deletions(-)
>
> --
> 2.43.0
Powered by blists - more mailing lists