linux-kernel - Re: [PATCH V6 1/2] rust: module: change author to an array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m2wmdfov3v.fsf@posteo.net>
Date: Mon, 24 Feb 2025 22:07:00 +0000
From: Charalampos Mitrodimas <charmitro@...teo.net>
To: Guilherme Giacomo Simoes <trintaeoitogc@...il.com>
Cc: a.hindborg@...nel.org,  alex.gaynor@...il.com,  aliceryhl@...gle.com,
  apw@...onical.com,  arnd@...db.de,  aswinunni01@...il.com,
  axboe@...nel.dk,  benno.lossin@...ton.me,  bhelgaas@...gle.com,
  bjorn3_gh@...tonmail.com,  boqun.feng@...il.com,  dakr@...nel.org,
  dwaipayanray1@...il.com,  ethan.twardy@...il.com,
  fujita.tomonori@...il.com,  gary@...yguo.net,
  gregkh@...uxfoundation.org,  joe@...ches.com,  lukas.bulwahn@...il.com,
  ojeda@...nel.org,  pbonzini@...hat.com,  tmgross@...ch.edu,
  walmeida@...rosoft.com,  rust-for-linux@...r.kernel.org,
  linux-kernel@...r.kernel.org,  Miguel Ojeda
 <miguel.ojeda.sandonis@...il.com>
Subject: Re: [PATCH V6 1/2] rust: module: change author to an array

Guilherme Giacomo Simoes <trintaeoitogc@...il.com> writes:

> In the module! macro, the author field is currently of type String.
> Since modules can have multiple authors, this limitation prevents
> specifying more than one.
> Change the author field to Option<Vec<String>> to allow creating modules
> with multiple authors. Additionally, rename the field from author to
> authors to make it explicit that it can refer to multiple authors.  In
> modules that use the author field, update its value to an array of
> strings, and also rename it from author to authors.
>
> Suggested-by: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
> Link: https://github.com/Rust-for-Linux/linux/issues/244
> Signed-off-by: Guilherme Giacomo Simoes <trintaeoitogc@...il.com>
> ---
>  drivers/block/rnull.rs               |  2 +-
>  drivers/net/phy/ax88796b_rust.rs     |  2 +-
>  drivers/net/phy/qt2025.rs            |  2 +-
>  rust/kernel/net/phy.rs               |  4 ++--
>  rust/kernel/pci.rs                   |  2 +-
>  rust/kernel/platform.rs              |  2 +-
>  rust/macros/lib.rs                   |  6 +++---
>  rust/macros/module.rs                | 12 +++++++-----
>  samples/rust/rust_driver_faux.rs     |  2 +-
>  samples/rust/rust_driver_pci.rs      |  2 +-
>  samples/rust/rust_driver_platform.rs |  2 +-
>  samples/rust/rust_minimal.rs         |  2 +-
>  samples/rust/rust_misc_device.rs     |  2 +-
>  samples/rust/rust_print_main.rs      |  2 +-
>  14 files changed, 23 insertions(+), 21 deletions(-)

Rust side looks good to me. Thanks!

Reviewed-by: Charalampos Mitrodimas <charmitro@...teo.net>