linux-kernel - Re: [PATCH] binder: remove unneeded <linux/export.h> inclusion from binder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHRSSExQf+FxRm61Pk9egJ73fz+1tp4nUFzANMujg3ban2REgw@mail.gmail.com>
Date: Mon, 24 Feb 2025 15:26:56 -0800
From: Todd Kjos <tkjos@...gle.com>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Arve Hjønnevåg <arve@...roid.com>, 
	Todd Kjos <tkjos@...roid.com>, Martijn Coenen <maco@...roid.com>, 
	Joel Fernandes <joel@...lfernandes.org>, Christian Brauner <christian@...uner.io>, 
	Carlos Llamas <cmllamas@...gle.com>, Suren Baghdasaryan <surenb@...gle.com>, linux-kernel@...r.kernel.org, 
	Christian Brauner <brauner@...nel.org>
Subject: Re: [PATCH] binder: remove unneeded <linux/export.h> inclusion from binder_internal.h

On Mon, Feb 17, 2025 at 3:28 AM Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> binder_internal.h is included only in the following two C files:
>
>   $ git grep binder_internal.h
>   drivers/android/binder.c:#include "binder_internal.h"
>   drivers/android/binderfs.c:#include "binder_internal.h"
>
> Neither of these files use the EXPORT_SYMBOL macro, so including
> <linux/export.h> is unnecessary.
>
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>

Acked-by: Todd Kjos <tkjos@...gle.com>

> ---
>
>  drivers/android/binder_internal.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/android/binder_internal.h b/drivers/android/binder_internal.h
> index e4eb8357989c..6a66c9769c6c 100644
> --- a/drivers/android/binder_internal.h
> +++ b/drivers/android/binder_internal.h
> @@ -3,7 +3,6 @@
>  #ifndef _LINUX_BINDER_INTERNAL_H
>  #define _LINUX_BINDER_INTERNAL_H
>
> -#include <linux/export.h>
>  #include <linux/fs.h>
>  #include <linux/list.h>
>  #include <linux/miscdevice.h>
> --
> 2.43.0
>