linux-kernel - Re: [PATCH] RDMA/core: fix a NULL-pointer dereference in hw_stat_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250224233004.GD520155@nvidia.com>
Date: Mon, 24 Feb 2025 19:30:04 -0400
From: Jason Gunthorpe <jgg@...dia.com>
To: Roman Gushchin <roman.gushchin@...ux.dev>
Cc: Parav Pandit <parav@...lanox.com>, Leon Romanovsky <leon@...nel.org>,
	Maher Sanalla <msanalla@...dia.com>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] RDMA/core: fix a NULL-pointer dereference in
 hw_stat_device_show()

On Mon, Feb 24, 2025 at 11:22:29PM +0000, Roman Gushchin wrote:
> On Mon, Feb 24, 2025 at 03:16:46PM +0000, Parav Pandit wrote:
> > 
> > 
> > > From: Jason Gunthorpe <jgg@...dia.com>
> > > Sent: Monday, February 24, 2025 8:41 PM
> > > 
> > > On Sat, Feb 22, 2025 at 06:34:21PM +0000, Parav Pandit wrote:
> > > > ib_setup_device_attrs() should be merged to ib_setup_port_attrs() by
> > > > renaming ib_setup_port_attrs() to be generic.  To utilize the group
> > > > initialization ib_setup_port_attrs() needs to move up before
> > > > device_add().
> > > 
> > > It needs more than that, somehow you have to maintain two groups list or
> > > somehow remove the coredev->dev.groups assignment..
> > > 
> > I was thinking that if both device and port attr setup is done in
> > same function, there is knowledge of is_full_dev that can be used
> > for device level hw_stats setup. (similar to how its done at port
> > level).
> 
> Given that there is a bit of discussion on how to move forward with this,
> can we please merge the trivial fix in the mean time? (Just sent out v2 with
> the fixed commit log).

Well, the issue now is the ABI break

If the right answer is to remove the sysfs entirely then it doesn't
make sense to make it work in the stable and LTS kernels since that
would create users. Currently it is fully broken so there are no
users. Can we say that so certainly after it is fixed?

Jason