linux-kernel - Re: [PATCH] ASoC: atmel: atmel-classd: Use str_enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250224072614.6811-1-andrei.simion@microchip.com>
Date: Mon, 24 Feb 2025 09:26:15 +0200
From: Andrei Simion <andrei.simion@...rochip.com>
To: <thorsten.blum@...ux.dev>
CC: <alexandre.belloni@...tlin.com>, <andrei.simion@...rochip.com>,
	<broonie@...nel.org>, <claudiu.beznea@...on.dev>, <lgirdwood@...il.com>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
	<linux-sound@...r.kernel.org>, <nicolas.ferre@...rochip.com>,
	<perex@...ex.cz>, <tiwai@...e.com>
Subject: Re: [PATCH] ASoC: atmel: atmel-classd: Use str_enabled_disabled() helper

Hi,

On 23.02.2025 00:59, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_enabled_disabled() helper
> function.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>

Reviewed-by: Andrei Simion <andrei.simion@...rochip.com>

> ---
>  sound/soc/atmel/atmel-classd.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/atmel/atmel-classd.c b/sound/soc/atmel/atmel-classd.c
> index ba314b279919..1f8c60d2de82 100644
> --- a/sound/soc/atmel/atmel-classd.c
> +++ b/sound/soc/atmel/atmel-classd.c
> @@ -11,6 +11,7 @@
>  #include <linux/module.h>
>  #include <linux/platform_device.h>
>  #include <linux/regmap.h>
> +#include <linux/string_choices.h>
>  #include <sound/core.h>
>  #include <sound/dmaengine_pcm.h>
>  #include <sound/pcm_params.h>
> @@ -275,7 +276,7 @@ static int atmel_classd_component_probe(struct snd_soc_component *component)
>  	dev_info(component->dev,
>  		"PWM modulation type is %s, non-overlapping is %s\n",
>  		pwm_type[pdata->pwm_type],
> -		pdata->non_overlap_enable?"enabled":"disabled");
> +		str_enabled_disabled(pdata->non_overlap_enable));
>
>  	return 0;
>  }

Best Regards,
Andrei Simion