linux-kernel - Re: [PATCH v3 0/2] Enable support for error detection in CSI2RX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3vci66duq6uowpavyo7ovjqrdgde2zswmbs6xwo6xv4lxcpy7m@myrohugxcgxb>
Date: Mon, 24 Feb 2025 13:40:01 +0530
From: Jai Luthra <jai.luthra@...ux.dev>
To: Yemike Abhilash Chandra <y-abhilashchandra@...com>
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, 
	devicetree@...r.kernel.org, mripard@...nel.org, mchehab@...nel.org, robh@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org, devarsht@...com, vaishnav.a@...com, 
	r-donadkar@...com, u-kumar1@...com
Subject: Re: [PATCH v3 0/2] Enable support for error detection in CSI2RX

On Fri, Feb 21, 2025 at 05:33:35PM +0530, Yemike Abhilash Chandra wrote:
> This patch series enables the csi2rx_err_irq interrupt to record any errors
> that occur during streaming. It also adds support for the VIDIOC_LOG_STATUS
> ioctl, which outputs the current device status to the kernel log.
> 
> The IRQ handler records any errors encountered during streaming.
> Additionally, VIDIOC_LOG_STATUS can be invoked from user space to retrieve
> the latest status.
> 
> Changelog:
> Changes in v3:
> - Address Krzysztof's review comment to drop minItems from the bindings.
> - Collect Acked-by from Krzysztof.
> - Address Jai's review comment to enable FIFO overflow bits in the mask 
>   only for the source pads that have an active remote.
> - Drop TI-specific interrupt and have support for only two interrupts 
>   that are common across all vendors.
> - Address Changhuang's review to use pdev directly to get the interrupt.
> - Set the interrupt mask register only if the interrupt is defined in the DT.
> 
> V1: https://lore.kernel.org/all/20250217130013.2802293-1-y-abhilashchandra@ti.com/
> 
> Logs with interrupt in DT: https://gist.github.com/Yemike-Abhilash-Chandra/5bd2dfb4219686ddf389e94d563a2ab1
> Logs without interrupt in DT: https://gist.github.com/Yemike-Abhilash-Chandra/31d8c840b5a4f677fde88373defed2cb 
> 

Tested-by: Jai Luthra <jai.luthra@...ux.dev> [on SK-AM62A]

> 
> Yemike Abhilash Chandra (2):
>   dt-bindings: media: cdns,csi2rx.yaml: Add optional interrupts for
>     cdns-csi2rx
>   media: cadence: csi2rx: Enable csi2rx_err_irq interrupt and add
>     support for VIDIOC_LOG_STATUS
> 
>  .../bindings/media/cdns,csi2rx.yaml           |   8 ++
>  drivers/media/platform/cadence/cdns-csi2rx.c  | 125 ++++++++++++++++++
>  2 files changed, 133 insertions(+)
> 
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)