linux-kernel - Re: [PATCH] Bluetooth: btusb: Configure altsetting for USER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2ab0d1c5-1bfe-4ef3-b23d-fee0ae1d7ad6@molgen.mpg.de>
Date: Mon, 24 Feb 2025 09:42:41 +0100
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Hsin-chen Chuang <chharry@...gle.com>
Cc: linux-bluetooth@...r.kernel.org, luiz.dentz@...il.com,
 gregkh@...uxfoundation.org, chromeos-bluetooth-upstreaming@...omium.org,
 Hsin-chen Chuang <chharry@...omium.org>,
 Marcel Holtmann <marcel@...tmann.org>, Ying Hsu <yinghsu@...omium.org>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: btusb: Configure altsetting for USER_CHANNEL

Dear Hsin-chen,


Thank you for your patch.

Am 24.02.25 um 03:24 schrieb Hsin-chen Chuang:
> From: Hsin-chen Chuang <chharry@...omium.org>
> 
> Automatically configure the altsetting for USER_CHANNEL when a SCO is
> connected or disconnected. This adds support for the USER_CHANNEL to
> transfer SCO data over USB transport.

Should you re-spin, it’d be great if you elaborated a little more. 
Especially for the motivation. It’d be also great, if you added how to 
test this.

> Fixes: b16b327edb4d ("Bluetooth: btusb: add sysfs attribute to control USB alt setting")
> Signed-off-by: Hsin-chen Chuang <chharry@...omium.org>
> ---
> 
>   drivers/bluetooth/btusb.c | 224 +++++++++++++++++++++++++++++++-------
>   1 file changed, 186 insertions(+), 38 deletions(-)

[…]


Kind regards,

Paul