linux-kernel - Re: [PATCH] staging: rtl8723bs: select CONFIG_CRYPTO_LIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <494bfb9c-0000-44fb-b33a-e42422488c95@redhat.com>
Date: Mon, 24 Feb 2025 09:53:36 +0100
From: Hans de Goede <hdegoede@...hat.com>
To: Yeking@...54.com, linux-kernel@...r.kernel.org
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Peter Robinson <pbrobinson@...il.com>, Fabio Aiuto <fabioaiuto83@...il.com>,
 linux-staging@...ts.linux.dev
Subject: Re: [PATCH] staging: rtl8723bs: select CONFIG_CRYPTO_LIB_AES

Hi,

On 22-Feb-25 8:36 PM, Yeking@...54.com wrote:
> From: 谢致邦 (XIE Zhibang) <Yeking@...54.com>
> 
> This fixes the following issue:
> ERROR: modpost: "aes_expandkey" [drivers/staging/rtl8723bs/r8723bs.ko]
> undefined!
> ERROR: modpost: "aes_encrypt" [drivers/staging/rtl8723bs/r8723bs.ko]
> undefined!
> 
> Fixes: 7d40753d8820 ("staging: rtl8723bs: use in-kernel aes encryption in OMAC1 routines")
> Fixes: 3d3a170f6d80 ("staging: rtl8723bs: use in-kernel aes encryption")
> Signed-off-by: 谢致邦 (XIE Zhibang) <Yeking@...54.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans



> ---
>  drivers/staging/rtl8723bs/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/rtl8723bs/Kconfig b/drivers/staging/rtl8723bs/Kconfig
> index 8d48c61961a6..353e6ee2c145 100644
> --- a/drivers/staging/rtl8723bs/Kconfig
> +++ b/drivers/staging/rtl8723bs/Kconfig
> @@ -4,6 +4,7 @@ config RTL8723BS
>  	depends on WLAN && MMC && CFG80211
>  	depends on m
>  	select CRYPTO
> +	select CRYPTO_LIB_AES
>  	select CRYPTO_LIB_ARC4
>  	help
>  	This option enables support for RTL8723BS SDIO drivers, such as