linux-kernel - Re: [PATCH v4 1/2] arm64: dts: mediatek: mt8395-genio-1200-evk: add support for TCPC port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z7vRUmETQaYRbEyZ@git-send.richtek.com>
Date: Mon, 24 Feb 2025 09:54:26 +0800
From: ChiYuan Huang <cy_huang@...htek.com>
To: Macpaul Lin (林智斌) <Macpaul.Lin@...iatek.com>
CC: "linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "robh@...nel.org"
	<robh@...nel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
	Alexandre Mergnat <amergnat@...libre.com>, "fparent@...libre.com"
	<fparent@...libre.com>, Bear Wang (萩原惟德)
	<bear.wang@...iatek.com>, "linux-usb@...r.kernel.org"
	<linux-usb@...r.kernel.org>, Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>, "macpaul@...il.com"
	<macpaul@...il.com>, Pablo Sun (孫毓翔)
	<pablo.sun@...iatek.com>, "simon.sun@...jingtech.com"
	<simon.sun@...jingtech.com>, Yow-shin Liou (劉祐炘)
	<yow-shin.liou@...iatek.com>, Chris-qj Chen (陳奇進)
	<Chris-qj.Chen@...iatek.com>
Subject: Re: [PATCH v4 1/2] arm64: dts: mediatek: mt8395-genio-1200-evk: add
 support for TCPC port

On Fri, Feb 21, 2025 at 11:39:09AM +0000, Macpaul Lin (林智斌) wrote:
> On Thu, 2025-02-20 at 16:58 +0100, AngeloGioacchino Del Regno wrote:
> > 
> > 
> 
> [snip]
> 
> > > +             tcpc {
> > > +                     compatible = "mediatek,mt6360-tcpc";
> > > +                     interrupts-extended = <&pio 17
> > > IRQ_TYPE_LEVEL_LOW>;
> > > +                     interrupt-names = "PD_IRQB";
> > > +
> > > +                     connector {
> > > +                             compatible = "usb-c-connector";
> > > +                             label = "USB-C";
> > > +                             data-role = "dual";
> > > +                             op-sink-microwatt = <10000000>;
> > > +                             power-role = "dual";
> > > +                             try-power-role = "sink";
> > 
> > Would be appreciated if you could also complete the node by adding
> > the pd-revision
> > property, enabling full USBC Power Delivery for the MT6360 PMIC.
> > 
> 
> Well, I have no idea about the pd-revision of MT6360.
> I could found MT6360 supports PD 3.0 according to the datasheet,
> however, I have no idea about the other fields like major and minor
> values. Dear ChiYuan, could you help to provide the value of pd-
> revision? The property has been defined in 
> Documentation/devicetree/bindings/connector/usb-connector.yaml.
> 
Hi, Macpaul:

You can specify the version information to 3.1 version 1.6.
Just add the below property into the 'connector' node.

pd-revision = /bits/ 8 <0x03 0x01 0x01 0x06>;

Regards,
ChiYuan
......