linux-kernel - Re: [PATCH v3 3/3] drm/tiny: add driver for Apple Touch Bars in x86 Macs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PN3PR01MB95974767785F92606B5EA96EB8C02@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>
Date: Mon, 24 Feb 2025 11:57:47 +0000
From: Aditya Garg <gargaditya08@...e.com>
To: "andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>
CC: Thomas Zimmermann <tzimmermann@...e.de>, "pmladek@...e.com"
	<pmladek@...e.com>, Steven Rostedt <rostedt@...dmis.org>,
	"linux@...musvillemoes.dk" <linux@...musvillemoes.dk>,
	"senozhatsky@...omium.org" <senozhatsky@...omium.org>, Jonathan Corbet
	<corbet@....net>, "maarten.lankhorst@...ux.intel.com"
	<maarten.lankhorst@...ux.intel.com>, "mripard@...nel.org"
	<mripard@...nel.org>, "airlied@...il.com" <airlied@...il.com>,
	"simona@...ll.ch" <simona@...ll.ch>, Andrew Morton
	<akpm@...ux-foundation.org>, "apw@...onical.com" <apw@...onical.com>,
	"joe@...ches.com" <joe@...ches.com>, "dwaipayanray1@...il.com"
	<dwaipayanray1@...il.com>, "lukas.bulwahn@...il.com"
	<lukas.bulwahn@...il.com>, "sumit.semwal@...aro.org"
	<sumit.semwal@...aro.org>, "christian.koenig@....com"
	<christian.koenig@....com>, Kerem Karabay <kekrby@...il.com>, Aun-Ali Zaidi
	<admin@...eit.net>, Orlando Chamberlain <orlandoch.dev@...il.com>, Atharva
 Tiwari <evepolonium@...il.com>, "linux-doc@...r.kernel.org"
	<linux-doc@...r.kernel.org>, Linux Kernel Mailing List
	<linux-kernel@...r.kernel.org>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "linaro-mm-sig@...ts.linaro.org"
	<linaro-mm-sig@...ts.linaro.org>, Hector Martin <marcan@...can.st>,
	"linux@...linux.org.uk" <linux@...linux.org.uk>, "asahi@...ts.linux.dev"
	<asahi@...ts.linux.dev>, Sven Peter <sven@...npeter.dev>, Janne Grunau
	<j@...nau.net>
Subject: Re: [PATCH v3 3/3] drm/tiny: add driver for Apple Touch Bars in x86
 Macs



> On 24 Feb 2025, at 5:13 PM, andriy.shevchenko@...ux.intel.com wrote:
> 
> On Mon, Feb 24, 2025 at 11:20:12AM +0000, Aditya Garg wrote:
>> 
>>> 
>>> It would be nice to see the difference in the code generation for the all
>>> __packed vs. only those that require it.
>>> 
>>>> At least it's clear then
>>>> what happens. And if your hardware requires this, you can't do much anyway.
>>> 
>>> One aspect (member level alignment) is clear but the other is not
>>> (object level alignment). I dunno if it makes sense to be pedantic about this,
>>> but would like to see the binary outcome asked for.
>> 
>> Hex dump of the compiled binary:
> 
> Oh, sorry I wasn't clear. We have a script called bloat-o-meter for these
> purposes. Please, run it with old and new binaries as parameters and share the
> output.

aditya@...Book:~/linux$ ./scripts/bloat-o-meter $PACKED $UNPACKED
add/remove: 0/0 grow/shrink: 0/0 up/down: 0/0 (0)
Function                                     old     new   delta
Total: Before=13286, After=13286, chg +0.00%

aditya@...Book:~/linux$ ./scripts/bloat-o-meter $PACKED $UNPACKED -c
add/remove: 0/0 grow/shrink: 0/0 up/down: 0/0 (0)
Function                                     old     new   delta
Total: Before=4957, After=4957, chg +0.00%
add/remove: 0/0 grow/shrink: 0/0 up/down: 0/0 (0)
Data                                         old     new   delta
Total: Before=1560, After=1560, chg +0.00%
add/remove: 0/0 grow/shrink: 0/0 up/down: 0/0 (0)
RO Data                                      old     new   delta
Total: Before=6769, After=6769, chg +0.00%

aditya@...Book:~/linux$ ./scripts/bloat-o-meter $PACKED $UNPACKED -d
add/remove: 0/0 grow/shrink: 0/0 up/down: 0/0 (0)
Data                                         old     new   delta
Total: Before=8329, After=8329, chg +0.00%

aditya@...Book:~/linux$ ./scripts/bloat-o-meter $PACKED $UNPACKED -t
add/remove: 0/0 grow/shrink: 0/0 up/down: 0/0 (0)
Function                                     old     new   delta
Total: Before=4957, After=4957, chg +0.00%

> 
> --
> With Best Regards,
> Andy Shevchenko
> 
>