linux-kernel - Re: [PATCH v2] LoongArch: acpi: Eliminate superfluous get_numa_distances

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAhV-H5RTVwkHKkHx19xA5HuMgret10jSYuCCgOW5uaF4Z_R5Q@mail.gmail.com>
Date: Tue, 25 Feb 2025 20:42:51 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: WangYuli <wangyuli@...ontech.com>
Cc: kernel@...0n.name, maobibo@...ngson.cn, guanwentao@...ontech.com, 
	loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	zhanjun@...ontech.com, niecheng1@...ontech.com, chenlinxuan@...ontech.com
Subject: Re: [PATCH v2] LoongArch: acpi: Eliminate superfluous get_numa_distances_cnt()

Applied, thanks.

Huacai

On Tue, Feb 25, 2025 at 2:48 AM WangYuli <wangyuli@...ontech.com> wrote:
>
> In LoongArch, get_numa_distances_cnt() was not in use, resulting in
> a compiler warning.
>
> Fix follow errors with clang-18 when W=1e:
>
> arch/loongarch/kernel/acpi.c:259:28: error: unused function 'get_numa_distances_cnt' [-Werror,-Wunused-function]
>   259 | static inline unsigned int get_numa_distances_cnt(struct acpi_table_slit *slit)
>       |                            ^~~~~~~~~~~~~~~~~~~~~~
> 1 error generated.
>
> Link: https://lore.kernel.org/all/Z7bHPVUH4lAezk0E@kernel.org/
> Signed-off-by: Yuli Wang <wangyuli@...ontech.com>
> ---
> Changelog:
>  *v1->v2: Drop the relocation and one more useless variable.
> ---
>  arch/loongarch/kernel/acpi.c | 12 ------------
>  1 file changed, 12 deletions(-)
>
> diff --git a/arch/loongarch/kernel/acpi.c b/arch/loongarch/kernel/acpi.c
> index ee471a80763e..193f81920074 100644
> --- a/arch/loongarch/kernel/acpi.c
> +++ b/arch/loongarch/kernel/acpi.c
> @@ -249,18 +249,6 @@ static __init int setup_node(int pxm)
>         return acpi_map_pxm_to_node(pxm);
>  }
>
> -/*
> - * Callback for SLIT parsing.  pxm_to_node() returns NUMA_NO_NODE for
> - * I/O localities since SRAT does not list them.  I/O localities are
> - * not supported at this point.
> - */
> -unsigned int numa_distance_cnt;
> -
> -static inline unsigned int get_numa_distances_cnt(struct acpi_table_slit *slit)
> -{
> -       return slit->locality_count;
> -}
> -
>  void __init numa_set_distance(int from, int to, int distance)
>  {
>         if ((u8)distance != distance || (from == to && distance != LOCAL_DISTANCE)) {
> --
> 2.47.2
>