linux-kernel - Re: [RFC] hwmon: (acpi_power_meter) Replace hwmon_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8b59c8d0-4710-48ab-ad70-b2eddc74fa9e@roeck-us.net>
Date: Tue, 25 Feb 2025 05:01:04 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Huisong Li <lihuisong@...wei.com>, jdelvare@...e.com
Cc: linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
 zhanjie9@...ilicon.com, zhenglifeng1@...wei.com, liuyonglong@...wei.com
Subject: Re: [RFC] hwmon: (acpi_power_meter) Replace hwmon_device_register

On 2/25/25 00:51, Huisong Li wrote:
> When load this mode, we can see the following log:
> "power_meter ACPI000D:00: hwmon_device_register() is deprecated. Please
>   convert the driver to use hwmon_device_register_with_info()."
> 
> So replace hwmon_device_register with hwmon_device_register_with_info.
> 
> To avoid any changes in the display of some sysfs interfaces, some of
> necessary changes in hwmon.c must be made:
> 1> For 'power1_average_interval_max/min' interface, insert 'average' to the
>     string corresponding to hwmon_power_average_interval_max/max in
>     hwmon_power_attr_templates[]. I guess that is what's missing.
> 2> Add some string attributes in power sensor type because of below items:
>     a) power1_accuracy  --> display like '90.0%'
>     b) power1_cap_hyst  --> display 'unknown' when its value is 0xFFFFFFFF
>     c) power1_average_min/max --> display 'unknown' when its value is
>                                   negative.
> Note: All the attributes modified above in hwmon core are not used by other
> drivers.
> 

That is not a reason to change the ABI, much less so hiding the change
in a driver patch.

Guenter