linux-kernel - Re: [PATCH v3 1/8] dt-bindings: reset: audiomix: Add reset ids for EARC and DSP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f4466c280bfef24be5d998299df450aa02ff2973.camel@pengutronix.de>
Date: Tue, 25 Feb 2025 14:12:49 +0100
From: Philipp Zabel <p.zabel@...gutronix.de>
To: Daniel Baluta <daniel.baluta@....com>, robh@...nel.org,
 krzk+dt@...nel.org,  shawnguo@...nel.org, mathieu.poirier@...aro.org
Cc: conor+dt@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de, 
 festevam@...il.com, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org,  imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org,  linux-remoteproc@...r.kernel.org,
 andersson@...nel.org, Frank.Li@....com,  peng.fan@....com,
 laurentiu.mihalcea@....com, iuliana.prodan@....com
Subject: Re: [PATCH v3 1/8] dt-bindings: reset: audiomix: Add reset ids for
 EARC and DSP

On Di, 2025-02-25 at 12:19 +0200, Daniel Baluta wrote:
> Add reset ids used for EARC and DSP on i.MX8MP platform.
> 
> Signed-off-by: Daniel Baluta <daniel.baluta@....com>
> Acked-by: Rob Herring (Arm) <robh@...nel.org>
> Reviewed-by: Frank Li <Frank.Li@....com>
> ---
>  include/dt-bindings/reset/imx8mp-reset-audiomix.h | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>  create mode 100644 include/dt-bindings/reset/imx8mp-reset-audiomix.h
> 
> diff --git a/include/dt-bindings/reset/imx8mp-reset-audiomix.h b/include/dt-bindings/reset/imx8mp-reset-audiomix.h
> new file mode 100644
> index 000000000000..3349bf311764
> --- /dev/null
> +++ b/include/dt-bindings/reset/imx8mp-reset-audiomix.h
> @@ -0,0 +1,13 @@
> +/* SPDX-License-Identifier: GPL-2.0-only OR MIT */
> +/*
> + * Copyright 2025 NXP
> + */
> +
> +#ifndef DT_BINDING_RESET_IMX8MP_AUDIOMIX_H
> +#define DT_BINDING_RESET_IMX8MP_AUDIOMIX_H
> +
> +#define IMX8MP_AUDIOMIX_EARC		0
> +#define IMX8MP_AUDIOMIX_EARC_PHY	1
> +#define IMX8MP_AUDIOMIX_DSP		2

How about calling these IMX8MP_AUDIOMIX_EARC_RESET,
IMX8MP_AUDIOMIX_EARC_PHY_RESET, and IMX8MP_AUDIOMIX_DSP_STALL instead?

regards
Philipp