linux-kernel - Re: [PATCH 3/3] gpiolib: don't double-check the gc->get callback's existence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z73Dp5EH3sHMZDZ7@smile.fi.intel.com>
Date: Tue, 25 Feb 2025 15:20:39 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Linus Walleij <linus.walleij@...aro.org>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 3/3] gpiolib: don't double-check the gc->get callback's
 existence

On Tue, Feb 25, 2025 at 12:56:25PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> gpiochip_get() is called only in two places: in gpio_chip_get_value()
> and in gpiochip_get_multiple() where the existence of the gc->get()
> callback is already checked. It makes sense to unduplicate the check by
> moving it one level up the stack.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

-- 
With Best Regards,
Andy Shevchenko