linux-kernel - Re: [PATCH v6 1/2] dt-bindings: PCI: dw: rockchip: Add rk3576 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1615a273-7a6f-4773-8c43-681e22ef661e@kernel.org>
Date: Tue, 25 Feb 2025 14:21:01 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kever Yang <kever.yang@...k-chips.com>
Cc: heiko@...ech.de, linux-rockchip@...ts.infradead.org,
 Sebastian Reichel <sebastian.reichel@...labora.com>,
 Simon Xue <xxm@...k-chips.com>, Conor Dooley <conor+dt@...nel.org>,
 Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
 linux-pci@...r.kernel.org, Krzysztof Wilczyński
 <kw@...ux.com>, linux-kernel@...r.kernel.org,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, devicetree@...r.kernel.org,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Shawn Lin <shawn.lin@...k-chips.com>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v6 1/2] dt-bindings: PCI: dw: rockchip: Add rk3576 support

On 25/02/2025 09:38, Kever Yang wrote:
>>>   
>>>   additionalProperties: true
>>>   
>>> +anyOf:
>> There is never syntax like that. Where did you find it (so we can fix
>> it)?


... therefore please use existing code as examples instead of coming
with entirely new syntax.

>>
>>> +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          contains:
>>> +            const: rockchip,rk3576-pcie
>> This does not belong to common schema, but to device specific. I don't
>> see this compatible in this common schema at all.
> 
> The common schema covers rockchip-dw-pcie.yaml and rockchip-dw-pcie-ep.yaml,
> 
> so I though I should add the if condition here.


You do not have compatibles here so you cannot add here code depending
on compatibles.

Best regards,
Krzysztof