linux-kernel - Re: [PATCH v4 9/9] drm/vkms: convert to use faux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49cd8502-f11e-4ade-a3a0-b16ce0c6282f@bootlin.com>
Date: Tue, 25 Feb 2025 14:51:40 +0100
From: Louis Chauvet <louis.chauvet@...tlin.com>
To: Thomas Zimmermann <tzimmermann@...e.de>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 linux-kernel@...r.kernel.org, Lyude Paul <lyude@...hat.com>,
 "Rafael J. Wysocki" <rafael@...nel.org>, Danilo Krummrich <dakr@...nel.org>,
 Alexander Lobakin <aleksander.lobakin@...el.com>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Bjorn Helgaas <bhelgaas@...gle.com>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 Liam Girdwood <lgirdwood@...il.com>, Lukas Wunner <lukas@...ner.de>,
 Mark Brown <broonie@...nel.org>, Maíra Canal
 <mairacanal@...eup.net>, Robin Murphy <robin.murphy@....com>,
 Simona Vetter <simona.vetter@...ll.ch>, Zijun Hu <quic_zijuhu@...cinc.com>,
 linux-usb@...r.kernel.org, rust-for-linux@...r.kernel.org,
 Haneen Mohammed <hamohammed.sa@...il.com>, Simona Vetter <simona@...ll.ch>,
 Melissa Wen <melissa.srw@...il.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, David Airlie <airlied@...il.com>,
 dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v4 9/9] drm/vkms: convert to use faux_device

Le 25/02/2025 à 12:41, Thomas Zimmermann a écrit :
> Hi
> 
> Am 10.02.25 um 15:37 schrieb Louis Chauvet:
>> On 10/02/25 - 13:30, Greg Kroah-Hartman wrote:
>>> The vkms driver does not need to create a platform device, as there is
>>> no real platform resources associated it,  it only did so because it was
>>> simple to do that in order to get a device to use for resource
>>> management of drm resources.  Change the driver to use the faux device
>>> instead as this is NOT a real platform device.
>>>
>>> Cc: Louis Chauvet <louis.chauvet@...tlin.com>
>>> Cc: Haneen Mohammed <hamohammed.sa@...il.com>
>>> Cc: Simona Vetter <simona@...ll.ch>
>>> Cc: Melissa Wen <melissa.srw@...il.com>
>>> Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>
>>> Cc: Maxime Ripard <mripard@...nel.org>
>>> Cc: Thomas Zimmermann <tzimmermann@...e.de>
>>> Cc: David Airlie <airlied@...il.com>
>>> Cc: dri-devel@...ts.freedesktop.org
>>> Reviewed-by: Lyude Paul <lyude@...hat.com>
>>> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>
> 
>> Tested-by: Louis Chauvet <louis.chauvet@...tlin.com>
>> Reviewed-by: Louis Chauvet <louis.chauvet@...tlin.com>
>>
>> Thanks for the modification, it seems to work.
> 
> Should this patch be merged through DRM trees? drm-misc-next is at
> v6.14-rc4 and has struct faux_device.

Hi,

I was not aware the faux-device was merged, as it is a new feature, I 
expected it to reach drm-misc-next on 6.15-rc1.

I plan to merge [1] today/tomorrow (well tested with platform_device), 
and then I will submit an updated version of this patch (only trivial 
conflicts, but never tested with multiple VKMS devices).

[1]:https://lore.kernel.org/all/20250218101214.5790-1-jose.exposito89@gmail.com/

Thanks,
Louis Chauvet

> Best regards
> Thomas
> 
> 
> 
>>
>> Louis chauvet
>>
> 

-- 
Louis Chauvet, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com