linux-kernel - Re: [PATCH 1/2] dt-bindings: regulator: add adi,adp5055-regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf90cf64-202b-456c-9a9a-ba33d0e68961@sirena.org.uk>
Date: Tue, 25 Feb 2025 14:06:31 +0000
From: Mark Brown <broonie@...nel.org>
To: Alexis Czezar Torreno <alexisczezar.torreno@...log.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: regulator: add adi,adp5055-regulator

On Tue, Feb 25, 2025 at 05:08:33PM +0800, Alexis Czezar Torreno wrote:

> +      adi,power-saving-mode:
> +        description:
> +          If present, enables power saving mode for
> +          individual channels.
> +        type: boolean

We have standard mode operations, please implement those.

> +      adi,output-discharge-function:
> +        description:
> +          If present, enable output discharge functionality
> +          for individual channels.
> +        type: boolean

set_active_discharge()

> +      adi,disable-delay-us:
> +        description:
> +          Configures the disable delay for each channel. Dependent on Tset.
> +        enum: [0, 5200, 10400, 15600, 20800, 26000, 31200, 36400]
> +        default: 0
> +
> +      adi,enable-delay-us:
> +        description:
> +          Configures the disable delay for each channel. Dependent on Tset.
> +        enum: [0, 2600, 5200, 7800, 10400, 13000, 15600, 18200]
> +        default: 0

This looks a lot like the driver should implemnt the enable_time()
and/or set_ramp_delay() operations and use the constraints to configure
this.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)