linux-kernel - [tip: x86/asm] selftests/x86/lam: Fix minor memory in do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <174049295877.10177.8031601958475058739.tip-bot2@tip-bot2>
Date: Tue, 25 Feb 2025 14:15:58 -0000
From: "tip-bot2 for liuye" <tip-bot2@...utronix.de>
To: linux-tip-commits@...r.kernel.org
Cc: liuye <liuye@...inos.cn>, Ingo Molnar <mingo@...nel.org>, x86@...nel.org,
 linux-kernel@...r.kernel.org
Subject: [tip: x86/asm] selftests/x86/lam: Fix minor memory in do_uring()

The following commit has been merged into the x86/asm branch of tip:

Commit-ID:     c4f23a9d6e7314060ccf5f089eda179cdcc3b36a
Gitweb:        https://git.kernel.org/tip/c4f23a9d6e7314060ccf5f089eda179cdcc3b36a
Author:        liuye <liuye@...inos.cn>
AuthorDate:    Tue, 14 Jan 2025 16:26:50 +08:00
Committer:     Ingo Molnar <mingo@...nel.org>
CommitterDate: Tue, 25 Feb 2025 15:03:06 +01:00

selftests/x86/lam: Fix minor memory in do_uring()

Exception branch returns without freeing 'fi'.

Signed-off-by: liuye <liuye@...inos.cn>
Signed-off-by: Ingo Molnar <mingo@...nel.org>
Link: https://lore.kernel.org/r/20250114082650.113105-1-liuye@kylinos.cn
---
 tools/testing/selftests/x86/lam.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/x86/lam.c b/tools/testing/selftests/x86/lam.c
index 4d4a765..309c93e 100644
--- a/tools/testing/selftests/x86/lam.c
+++ b/tools/testing/selftests/x86/lam.c
@@ -596,8 +596,10 @@ int do_uring(unsigned long lam)
 	fi->file_fd = file_fd;
 
 	ring = malloc(sizeof(*ring));
-	if (!ring)
+	if (!ring) {
+		free(fi);
 		return 1;
+	}
 
 	memset(ring, 0, sizeof(struct io_ring));