linux-kernel - Re: [PATCH 1/3] media: i2c: ov9282: use register definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPY8ntDYYPs90JVCLiZGqQAak=WOga90hgCns_TRWTxdrROPiw@mail.gmail.com>
Date: Tue, 25 Feb 2025 14:19:14 +0000
From: Dave Stevenson <dave.stevenson@...pberrypi.com>
To: Richard Leitner <richard.leitner@...ux.dev>
Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, linux-media@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] media: i2c: ov9282: use register definitions

Hi Richard

Thanks for the patch

On Tue, 25 Feb 2025 at 13:09, Richard Leitner <richard.leitner@...ux.dev> wrote:
>
> For better readability use already available register definitions in
> hard-coded common and mode register structs.
>
> Signed-off-by: Richard Leitner <richard.leitner@...ux.dev>

Reviewed-by: Dave Stevenson <dave.stevenson@...pberrypi.com>

> ---
>  drivers/media/i2c/ov9282.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c
> index 87e5d7ce5a47ee23a721ea39c0ab314c6fca6007..c926842257893c4da3319b847fab9908b5bdaec6 100644
> --- a/drivers/media/i2c/ov9282.c
> +++ b/drivers/media/i2c/ov9282.c
> @@ -296,8 +296,8 @@ static const struct ov9282_reg mode_1280x800_regs[] = {
>         {0x3813, 0x08},
>         {0x3814, 0x11},
>         {0x3815, 0x11},
> -       {0x3820, 0x40},
> -       {0x3821, 0x00},
> +       {OV9282_REG_TIMING_FORMAT_1, 0x40},
> +       {OV9282_REG_TIMING_FORMAT_2, 0x00},
>         {0x4003, 0x40},
>         {0x4008, 0x04},
>         {0x4009, 0x0b},
> @@ -327,8 +327,8 @@ static const struct ov9282_reg mode_1280x720_regs[] = {
>         {0x3813, 0x08},
>         {0x3814, 0x11},
>         {0x3815, 0x11},
> -       {0x3820, 0x3c},
> -       {0x3821, 0x84},
> +       {OV9282_REG_TIMING_FORMAT_1, 0x3c},
> +       {OV9282_REG_TIMING_FORMAT_2, 0x84},
>         {0x4003, 0x40},
>         {0x4008, 0x02},
>         {0x4009, 0x05},
> @@ -358,8 +358,8 @@ static const struct ov9282_reg mode_640x400_regs[] = {
>         {0x3813, 0x04},
>         {0x3814, 0x31},
>         {0x3815, 0x22},
> -       {0x3820, 0x60},
> -       {0x3821, 0x01},
> +       {OV9282_REG_TIMING_FORMAT_1, 0x60},
> +       {OV9282_REG_TIMING_FORMAT_2, 0x01},
>         {0x4008, 0x02},
>         {0x4009, 0x05},
>         {0x400c, 0x00},
>
> --
> 2.47.2
>
>