linux-kernel - Re: [PATCH 01/63] docs/dyndbg: update examples \012 to \n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3f5d7e90-0feb-48ef-8279-1644ce5f3d5b@bootlin.com>
Date: Tue, 25 Feb 2025 15:30:00 +0100
From: Louis Chauvet <louis.chauvet@...tlin.com>
To: Jim Cromie <jim.cromie@...il.com>, linux-kernel@...r.kernel.org,
	jbaron@...mai.com, gregkh@...uxfoundation.org, ukaszb@...omium.org
Cc: intel-gfx-trybot@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
	amd-gfx@...ts.freedesktop.org, intel-gvt-dev@...ts.freedesktop.org,
	intel-gfx@...ts.freedesktop.org, daniel.vetter@...ll.ch,
	tvrtko.ursulin@...ux.intel.com, jani.nikula@...el.com,
	ville.syrjala@...ux.intel.com
Subject: Re: [PATCH 01/63] docs/dyndbg: update examples \012 to \n



Le 25/01/2025 à 07:45, Jim Cromie a écrit :
> commit 47ea6f99d06e ("dyndbg: use ESCAPE_SPACE for cat control")
> 
> changed the control-file to display format strings with "\n" rather
> than "\012".  Update the docs to match the new reality.
> 
> Signed-off-by: Jim Cromie <jim.cromie@...il.com>

Hi Jim,

I think this patch is incomplete, I just tested and the \012 in [1] 
needs to be replaced too.

[1]:https://elixir.bootlin.com/linux/v6.14-rc3/source/Documentation/admin-guide/dynamic-debug-howto.rst#L39-L46

With this change:
Reviewed-by: Louis Chauvet <louis.chauvet@...tlin.com>
Tested-by: Louis Chauvet<louis.chauvet@...tlin.com>

> ---
>   Documentation/admin-guide/dynamic-debug-howto.rst | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Documentation/admin-guide/dynamic-debug-howto.rst
> index 7c036590cd07..691e0f7d4de1 100644
> --- a/Documentation/admin-guide/dynamic-debug-howto.rst
> +++ b/Documentation/admin-guide/dynamic-debug-howto.rst
> @@ -57,12 +57,12 @@ query/commands to the control file.  Example::
>     # grease the interface
>     :#> alias ddcmd='echo $* > /proc/dynamic_debug/control'
>   
> -  :#> ddcmd '-p; module main func run* +p'
> +  :#> ddcmd '-p; module main func run* +p'	# disable all, then enable main
>     :#> grep =p /proc/dynamic_debug/control
> -  init/main.c:1424 [main]run_init_process =p "  with arguments:\012"
> -  init/main.c:1426 [main]run_init_process =p "    %s\012"
> -  init/main.c:1427 [main]run_init_process =p "  with environment:\012"
> -  init/main.c:1429 [main]run_init_process =p "    %s\012"
> +  init/main.c:1424 [main]run_init_process =p "  with arguments:\n"
> +  init/main.c:1426 [main]run_init_process =p "    %s\n"
> +  init/main.c:1427 [main]run_init_process =p "  with environment:\n"
> +  init/main.c:1429 [main]run_init_process =p "    %s\n"
>   
>   Error messages go to console/syslog::
>   

-- 
Louis Chauvet, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com