linux-kernel - Re: [PATCH] platform/x86: asus-wmi: change quiet to low-power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <CAGwozwF-WVEgiAbWbRCiUaXf=BVa3KqmMJfs06trdMQHpTGmjQ@mail.gmail.com>
Date: Tue, 25 Feb 2025 16:21:14 +0100
From: Antheas Kapenekakis <lkml@...heas.dev>
To: Mario Limonciello <mario.limonciello@....com>
Cc: luke@...nes.dev, corentin.chary@...il.com, hdegoede@...hat.com,
	ilpo.jarvinen@...ux.intel.com, linux-kernel@...r.kernel.org,
	platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH] platform/x86: asus-wmi: change quiet to low-power

> The documentation says to look at platform_profile_choices.  To
> determine what is supported.  FWIW this is exactly what
> power-profiles-daemon does.

Yeah, this one is minor all things considered. Since there is a
justification. Even if user error is not the best of justifications.

But as I maintain a userspace TDP tool, I can tell you that if the
other issue is not fixed, /sys/firmware/acpi/platform_profile is no
longer trustworthy due to being able to occlude platform profiles. So
a mitigation will be needed for all userspace power utilities. But
there is actually very little use currently for
/sys/class/platform-profile as AMD pmf is mostly a NOOP, so I think
this would be premature and should be avoided.

While I do not have a large portfolio of ACPI collections for
Thinkpads, HP, Alienware, and Dell that have WMI drivers, I can see
amd-pmf popping up on a lot of the late 2024 models of GPD, Ayaneo,
Lenovo, and Asus, and going into 2025. So it is worthwhile fixing this
now once and for all.

Antheas