linux-kernel - Re: [PATCH v7 12/14] iommu/arm-smmu-v3: Introduce struct arm_smmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250225160225.GA593877@nvidia.com>
Date: Tue, 25 Feb 2025 12:02:25 -0400
From: Jason Gunthorpe <jgg@...dia.com>
To: Nicolin Chen <nicolinc@...dia.com>
Cc: Pranjal Shrivastava <praan@...gle.com>, kevin.tian@...el.com,
	corbet@....net, will@...nel.org, joro@...tes.org,
	suravee.suthikulpanit@....com, robin.murphy@....com,
	dwmw2@...radead.org, baolu.lu@...ux.intel.com, shuah@...nel.org,
	linux-kernel@...r.kernel.org, iommu@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org,
	linux-kselftest@...r.kernel.org, linux-doc@...r.kernel.org,
	eric.auger@...hat.com, jean-philippe@...aro.org, mdf@...nel.org,
	mshavit@...gle.com, shameerali.kolothum.thodi@...wei.com,
	smostafa@...gle.com, ddutile@...hat.com, yi.l.liu@...el.com,
	patches@...ts.linux.dev
Subject: Re: [PATCH v7 12/14] iommu/arm-smmu-v3: Introduce struct
 arm_smmu_vmaster

On Mon, Feb 24, 2025 at 03:45:33PM -0800, Nicolin Chen wrote:

> --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-iommufd.c
> +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-iommufd.c
> @@ -95,8 +95,6 @@ int arm_smmu_attach_prepare_vmaster(struct arm_smmu_attach_state *state,
>  
>  	iommu_group_mutex_assert(state->master->dev);
>  
> -	if (domain->type != IOMMU_DOMAIN_NESTED)
> -		return 0;
>  	nested_domain = to_smmu_nested_domain(domain);
>  
>  	/* Skip invalid vSTE */
> @@ -122,19 +120,9 @@ void arm_smmu_attach_commit_vmaster(struct arm_smmu_attach_state *state)
>  {
>  	struct arm_smmu_master *master = state->master;
>  
> -	mutex_lock(&master->smmu->streams_mutex);
> -	if (state->vmaster != master->vmaster) {
> -		kfree(master->vmaster);
> -		master->vmaster = state->vmaster;
> -	}
> -	mutex_unlock(&master->smmu->streams_mutex);
> -}
> -
> -void arm_smmu_master_clear_vmaster(struct arm_smmu_master *master)
> -{
>  	mutex_lock(&master->smmu->streams_mutex);
>  	kfree(master->vmaster);
> -	master->vmaster = NULL;
> +	master->vmaster = state->vmaster;
>  	mutex_unlock(&master->smmu->streams_mutex);
>  }

I'd leave the clear_vmaster just for clarity. Commit should not be
unpaired with prepare in the other functions.

It looks fine with this on top too

Reviewed-by: Jason Gunthorpe <jgg@...dia.com>

Jason