linux-kernel - Re: [PATCH v2] mm: Fix error handling in __filemap_get_folio() with FGP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKhLTr1HtH7gnSKSE+8LR9+MpNGYK0PYr8NGSTav-0sgf4y+gw@mail.gmail.com>
Date: Tue, 25 Feb 2025 13:04:04 -0300
From: "Raphael S. Carvalho" <raphaelsc@...lladb.com>
To: Christoph Hellwig <hch@....de>
Cc: Matthew Wilcox <willy@...radead.org>, linux-kernel@...r.kernel.org, 
	linux-xfs@...r.kernel.org, linux-mm@...ck.org, linux-fsdevel@...r.kernel.org, 
	djwong@...nel.org, Dave Chinner <david@...morbit.com>
Subject: Re: [PATCH v2] mm: Fix error handling in __filemap_get_folio() with FGP_NOWAIT

On Mon, Feb 24, 2025 at 1:15 PM Raphael S. Carvalho
<raphaelsc@...lladb.com> wrote:
>
> On Mon, Feb 24, 2025 at 1:02 PM Christoph Hellwig <hch@....de> wrote:
> >
> > On Mon, Feb 24, 2025 at 03:33:29PM +0000, Matthew Wilcox wrote:
> > > I don't think it needs a comment at all, but the memory allocation
> > > might be for something other than folios, so your suggested comment
> > > is misleading.
> >
> > Then s/folio/memory/
>
> The context of the comment is error handling. ENOMEM can come from
> either folio allocation / addition (there's an allocation for xarray
> node). So is it really wrong to say folios given the context of the
> comment? It's not supposed to be a generic comment, but rather one
> that applies to its context.
>
> Maybe this change:
> -                         * When NOWAIT I/O fails to allocate folios this could
> +                         * When NOWAIT I/O fails to allocate memory for folio
>
> Or perhaps just what hch suggested.

Matthew, please let me know what you think, so we can move forward
with this. Thanks.