linux-kernel - Re: [PATCH] media: i2c: Replace nested min() with single min3()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ef3f1c7e-30d8-4cdd-b07a-41162adf245d@web.de>
Date: Tue, 25 Feb 2025 17:34:21 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Qasim Ijaz <qasdev00@...il.com>, linux-media@...r.kernel.org,
 Benjamin Mugnier <benjamin.mugnier@...s.st.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Sylvain Petinot <sylvain.petinot@...s.st.com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] media: i2c: Replace nested min() with single min3()

…
> +++ b/drivers/media/i2c/vgxy61.c
> @@ -892,8 +892,8 @@ static u32 vgxy61_get_expo_long_max(struct vgxy61_dev *sensor,
>  	third_rot_max_expo = (sensor->frame_length / 71) * short_expo_ratio;
>
>  	/* Take the minimum from all rules */
> -	return min(min(first_rot_max_expo, second_rot_max_expo),
> -		   third_rot_max_expo);
> +	return min3(first_rot_max_expo, second_rot_max_expo,
> +		    third_rot_max_expo);
…

Can the following source code variant be applied?

+	return min3(first_rot_max_expo, second_rot_max_expo, third_rot_max_expo);


Regards,
Markus