linux-kernel - Re: [PATCH 1/2] firmware: cs_dsp: Remove async regmap writes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5814df5e-315e-4556-9196-df982716d9b8@sirena.org.uk>
Date: Tue, 25 Feb 2025 16:37:52 +0000
From: Mark Brown <broonie@...nel.org>
To: Richard Fitzgerald <rf@...nsource.cirrus.com>
Cc: tiwai@...e.com, linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org, patches@...nsource.cirrus.com
Subject: Re: [PATCH 1/2] firmware: cs_dsp: Remove async regmap writes

On Tue, Feb 25, 2025 at 04:22:49PM +0000, Richard Fitzgerald wrote:

> Ok. It was a very long time ago.
> Do you want a V2 with a commit message that doesn't libel the SPI
> framework?

No, it's fine - it's in CI already.

> FWIW switching to sync write reduced the download of small amp firmware
> by 200ms on a 1.67MHz SPI bus.

Yeah, with modern multi-core systems that's unsurprising especially
with a controller that does small writes synchronously - the cost of
locking on modern CPUs tends to blow out the overlapping of the
formatting with the I/O.  It's part of why maple tree caches don't do
async writes during sync.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)