[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20250225-bridge-connector-v4-0-7ecb07b09cad@kernel.org>
Date: Tue, 25 Feb 2025 17:43:48 +0100
From: Maxime Ripard <mripard@...nel.org>
To: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
Simona Vetter <simona@...ll.ch>, Andrzej Hajda <andrzej.hajda@...el.com>,
Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>,
Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>,
Douglas Anderson <dianders@...omium.org>
Cc: Herve Codina <herve.codina@...tlin.com>,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
Maxime Ripard <mripard@...nel.org>,
Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
Simona Vetter <simona.vetter@...ll.ch>
Subject: [PATCH v4 00/15] drm/bridge: Various quality of life improvements
Hi,
Here's a series of changes after to the KMS helpers and bridge API
following a bunch of reviews I did.
It's mostly centered across providing an easier time to deal with bridge
states, and a somewhat consistent with the other entities API.
It's build tested only, with arm64 allmodconfig.
Maxime
Signed-off-by: Maxime Ripard <mripard@...nel.org>
---
Changes in v4:
- Rebased on top of drm-misc-next-2025-02-20
- Changed the approach to helpers suggested by Sima, dropped the tags
affected by the rework
- Drop drm_bridge_state->crtc and connector fields
- Drop drm_bridge->encoder deprecation
- Introduced kunit tests
- Link to v3: https://lore.kernel.org/r/20250213-bridge-connector-v3-0-e71598f49c8f@kernel.org
Changes in v3:
- Add tags
- Fix compilation breakages
- Reword some commit messages
- Create drm_bridge_is_atomic() helper
- Retrieve the CRTC state through drm_atomic_get_new_crtc_state()
instead of crtc->state in bridges
- Fix ti-sn65dsi86
- Link to v2: https://lore.kernel.org/r/20250204-bridge-connector-v2-0-35dd6c834e08@kernel.org
Changes in v2:
- Pass the full atomic state to bridge atomic hooks
- Make attach take the encoder as a parameter
- Mark bridge->encoder as deprecated
- Rework the logic to detect if a bridge uses a state or not at
atomic_check time
- Add lockdep assertion to drm_bridge_get_current_state()
- Link to v1: https://lore.kernel.org/r/20250115-bridge-connector-v1-0-9a2fecd886a6@kernel.org
---
Maxime Ripard (15):
drm/bridge: Add encoder parameter to drm_bridge_funcs.attach
drm/bridge: Provide a helper to retrieve current bridge state
drm/tests: Add kunit tests for bridges
drm/atomic: Introduce helper to lookup connector by encoder
drm/tests: helpers: Create new helper to enable output
drm/tests: Create tests for drm_atomic
drm/bridge: Add helper to reset bridge pipeline
drm/tests: bridge: Provide tests for drm_bridge_reset_crtc
drm/bridge: ti-sn65dsi83: Switch to drm_bridge_reset_crtc
drm/bridge: Introduce drm_bridge_is_atomic() helper
drm/bridge: cdns-csi: Switch to atomic helpers
drm/bridge: tc358775: Switch to atomic commit
drm/bridge: tc358768: Stop disabling when failing to enable
drm/bridge: tc358768: Convert to atomic helpers
drm/bridge: ti-sn65dsi86: Use bridge_state crtc pointer
drivers/gpu/drm/Kconfig | 1 +
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 3 +-
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 3 +-
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 3 +-
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 +-
drivers/gpu/drm/bridge/analogix/anx7625.c | 3 +-
drivers/gpu/drm/bridge/aux-bridge.c | 3 +-
drivers/gpu/drm/bridge/aux-hpd-bridge.c | 1 +
drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 34 +-
.../gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 1 +
drivers/gpu/drm/bridge/chipone-icn6211.c | 6 +-
drivers/gpu/drm/bridge/chrontel-ch7033.c | 5 +-
drivers/gpu/drm/bridge/display-connector.c | 1 +
drivers/gpu/drm/bridge/fsl-ldb.c | 3 +-
drivers/gpu/drm/bridge/imx/imx-ldb-helper.c | 7 +-
drivers/gpu/drm/bridge/imx/imx-ldb-helper.h | 2 +-
drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c | 3 +-
drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c | 3 +-
.../gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c | 3 +-
drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c | 3 +-
drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c | 3 +-
drivers/gpu/drm/bridge/ite-it6263.c | 7 +-
drivers/gpu/drm/bridge/ite-it6505.c | 1 +
drivers/gpu/drm/bridge/ite-it66121.c | 3 +-
drivers/gpu/drm/bridge/lontium-lt8912b.c | 3 +-
drivers/gpu/drm/bridge/lontium-lt9211.c | 3 +-
drivers/gpu/drm/bridge/lontium-lt9611.c | 3 +-
drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 3 +-
drivers/gpu/drm/bridge/lvds-codec.c | 3 +-
.../drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c | 1 +
drivers/gpu/drm/bridge/microchip-lvds.c | 3 +-
drivers/gpu/drm/bridge/nwl-dsi.c | 3 +-
drivers/gpu/drm/bridge/nxp-ptn3460.c | 5 +-
drivers/gpu/drm/bridge/panel.c | 3 +-
drivers/gpu/drm/bridge/parade-ps8622.c | 1 +
drivers/gpu/drm/bridge/parade-ps8640.c | 3 +-
drivers/gpu/drm/bridge/samsung-dsim.c | 3 +-
drivers/gpu/drm/bridge/sii902x.c | 5 +-
drivers/gpu/drm/bridge/sil-sii8620.c | 1 +
drivers/gpu/drm/bridge/simple-bridge.c | 5 +-
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 +-
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 5 +-
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi2.c | 5 +-
drivers/gpu/drm/bridge/tc358762.c | 3 +-
drivers/gpu/drm/bridge/tc358764.c | 3 +-
drivers/gpu/drm/bridge/tc358767.c | 2 +
drivers/gpu/drm/bridge/tc358768.c | 41 ++-
drivers/gpu/drm/bridge/tc358775.c | 45 ++-
drivers/gpu/drm/bridge/tda998x_drv.c | 1 +
drivers/gpu/drm/bridge/thc63lvd1024.c | 3 +-
drivers/gpu/drm/bridge/ti-dlpc3433.c | 4 +-
drivers/gpu/drm/bridge/ti-sn65dsi83.c | 29 +-
drivers/gpu/drm/bridge/ti-sn65dsi86.c | 61 ++--
drivers/gpu/drm/bridge/ti-tdp158.c | 6 +-
drivers/gpu/drm/bridge/ti-tfp410.c | 5 +-
drivers/gpu/drm/bridge/ti-tpd12s015.c | 3 +-
drivers/gpu/drm/drm_atomic.c | 45 +++
drivers/gpu/drm/drm_bridge.c | 55 ++-
drivers/gpu/drm/imx/ipuv3/parallel-display.c | 3 +-
drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 5 +-
drivers/gpu/drm/mcde/mcde_dsi.c | 3 +-
drivers/gpu/drm/mediatek/mtk_dp.c | 3 +-
drivers/gpu/drm/mediatek/mtk_dpi.c | 3 +-
drivers/gpu/drm/mediatek/mtk_dsi.c | 3 +-
drivers/gpu/drm/mediatek/mtk_hdmi.c | 3 +-
drivers/gpu/drm/meson/meson_encoder_cvbs.c | 3 +-
drivers/gpu/drm/meson/meson_encoder_dsi.c | 3 +-
drivers/gpu/drm/meson/meson_encoder_hdmi.c | 3 +-
drivers/gpu/drm/msm/dsi/dsi_manager.c | 3 +-
drivers/gpu/drm/omapdrm/dss/dpi.c | 3 +-
drivers/gpu/drm/omapdrm/dss/dsi.c | 3 +-
drivers/gpu/drm/omapdrm/dss/hdmi4.c | 3 +-
drivers/gpu/drm/omapdrm/dss/hdmi5.c | 3 +-
drivers/gpu/drm/omapdrm/dss/sdi.c | 3 +-
drivers/gpu/drm/omapdrm/dss/venc.c | 3 +-
drivers/gpu/drm/renesas/rcar-du/rcar_lvds.c | 3 +-
drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c | 3 +-
drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c | 3 +-
drivers/gpu/drm/stm/lvds.c | 11 +-
drivers/gpu/drm/tests/Makefile | 2 +
drivers/gpu/drm/tests/drm_atomic_test.c | 153 +++++++++
drivers/gpu/drm/tests/drm_bridge_test.c | 376 +++++++++++++++++++++
drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 151 +++++----
drivers/gpu/drm/tests/drm_kunit_helpers.c | 61 ++++
drivers/gpu/drm/tidss/tidss_encoder.c | 3 +-
drivers/gpu/drm/vc4/vc4_dsi.c | 3 +-
drivers/gpu/drm/xlnx/zynqmp_dp.c | 3 +-
drivers/platform/arm64/acer-aspire1-ec.c | 3 +-
include/drm/drm_atomic.h | 3 +
include/drm/drm_bridge.h | 36 +-
include/drm/drm_kunit_helpers.h | 8 +
91 files changed, 1107 insertions(+), 239 deletions(-)
---
base-commit: e82e1a0c22d841f379b1c768469dcdaae650e443
change-id: 20250115-bridge-connector-f93194e267ff
Best regards,
--
Maxime Ripard <mripard@...nel.org>
Powered by blists - more mailing lists