linux-kernel - RE: [PATCH] i2c: mux: remove incorrect of_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PH0PR03MB6512C35E04DC43D004B6C35D8EC32@PH0PR03MB6512.namprd03.prod.outlook.com>
Date: Tue, 25 Feb 2025 16:39:50 +0000
From: "Hennerich, Michael" <Michael.Hennerich@...log.com>
To: Arnd Bergmann <arnd@...nel.org>, Peter Rosin <peda@...ntia.se>
CC: Arnd Bergmann <arnd@...db.de>, "Rob Herring (Arm)" <robh@...nel.org>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Thomas Zimmermann
	<tzimmermann@...e.de>,
        Laurent Pinchart
	<laurent.pinchart+renesas@...asonboard.com>,
        Uwe Kleine König <u.kleine-koenig@...libre.com>,
        Andi
 Shyti <andi.shyti@...nel.org>,
        "linux-i2c@...r.kernel.org"
	<linux-i2c@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] i2c: mux: remove incorrect of_match_ptr annotations



> -----Original Message-----
> From: Arnd Bergmann <arnd@...nel.org>
> Sent: Tuesday, February 25, 2025 5:37 PM
> To: Hennerich, Michael <Michael.Hennerich@...log.com>; Peter Rosin
> <peda@...ntia.se>
> Cc: Arnd Bergmann <arnd@...db.de>; Rob Herring (Arm) <robh@...nel.org>;
> Heiner Kallweit <hkallweit1@...il.com>; Thomas Zimmermann
> <tzimmermann@...e.de>; Laurent Pinchart
> <laurent.pinchart+renesas@...asonboard.com>; Uwe Kleine König <u.kleine-
> koenig@...libre.com>; Andi Shyti <andi.shyti@...nel.org>; linux-
> i2c@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] i2c: mux: remove incorrect of_match_ptr annotations
> 
> From: Arnd Bergmann <arnd@...db.de>
> 
> Building with W=1 shows a warning about ltc4306_of_match and
> i2c_mux_reg_of_match being unused when CONFIG_OF is disabled:
> 
>     drivers/i2c/muxes/i2c-mux-ltc4306.c:200:34: error: unused variable
> 'ltc4306_of_match' [-Werror,-Wunused-const-variable]
>     drivers/i2c/muxes/i2c-mux-reg.c:242:34: error: unused variable
> 'i2c_mux_reg_of_match' [-Werror,-Wunused-const-variable]
> 
> Acked-by: Peter Rosin <peda@...ntia.se>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Michael Hennerich <michael.hennerich@...log.com>

> ---
>  drivers/i2c/muxes/i2c-mux-ltc4306.c | 2 +-
>  drivers/i2c/muxes/i2c-mux-reg.c     | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/muxes/i2c-mux-ltc4306.c b/drivers/i2c/muxes/i2c-mux-
> ltc4306.c
> index 19a7c370946d..8a87f19bf5d5 100644
> --- a/drivers/i2c/muxes/i2c-mux-ltc4306.c
> +++ b/drivers/i2c/muxes/i2c-mux-ltc4306.c
> @@ -303,7 +303,7 @@ static void ltc4306_remove(struct i2c_client *client)
> static struct i2c_driver ltc4306_driver = {
>  	.driver		= {
>  		.name	= "ltc4306",
> -		.of_match_table = of_match_ptr(ltc4306_of_match),
> +		.of_match_table = ltc4306_of_match,
>  	},
>  	.probe		= ltc4306_probe,
>  	.remove		= ltc4306_remove,
> diff --git a/drivers/i2c/muxes/i2c-mux-reg.c b/drivers/i2c/muxes/i2c-mux-reg.c
> index dfa472d514cc..1e566ea92bc9 100644
> --- a/drivers/i2c/muxes/i2c-mux-reg.c
> +++ b/drivers/i2c/muxes/i2c-mux-reg.c
> @@ -250,7 +250,7 @@ static struct platform_driver i2c_mux_reg_driver = {
>  	.remove = i2c_mux_reg_remove,
>  	.driver	= {
>  		.name	= "i2c-mux-reg",
> -		.of_match_table = of_match_ptr(i2c_mux_reg_of_match),
> +		.of_match_table = i2c_mux_reg_of_match,
>  	},
>  };
> 
> --
> 2.39.5