linux-kernel - Re: [PATCH 4/7] power: supply: all: switch psy_cfg from of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0af9a7d7-e710-4634-ade8-6a3cf324bb5e@linux.alibaba.com>
Date: Tue, 25 Feb 2025 11:39:48 +0800
From: Baolin Wang <baolin.wang@...ux.alibaba.com>
To: Sebastian Reichel <sebastian.reichel@...labora.com>,
 Sebastian Reichel <sre@...nel.org>, Mark Brown <broonie@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Linus Walleij <linus.walleij@...aro.org>, Hans de Goede <hdegoede@...hat.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Chen-Yu Tsai <wens@...e.org>,
 Matti Vaittinen <mazziesaccount@...il.com>, Pali Rohár
 <pali@...nel.org>, Paul Cercueil <paul@...pouillou.net>,
 Samuel Holland <samuel@...lland.org>, David Lechner <david@...hnology.com>,
 Krzysztof Kozlowski <krzk@...nel.org>,
 Marek Szyprowski <m.szyprowski@...sung.com>,
 Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>,
 Purism Kernel Team <kernel@...i.sm>, Bartosz Golaszewski <brgl@...ev.pl>,
 Konrad Dybcio <konradybcio@...nel.org>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Orson Zhai <orsonzhai@...il.com>, Chunyan Zhang <zhang.lyra@...il.com>,
 linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-usb@...r.kernel.org
Subject: Re: [PATCH 4/7] power: supply: all: switch psy_cfg from of_node to
 fwnode



On 2025/2/25 07:21, Sebastian Reichel wrote:
> When registering a power-supply device, either a of_node or the more
> recent fwnode can be supplied. Since fwnode can also contain an of_node,
> let's try to get rid of it.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.com>
> ---

[snip]

>   drivers/power/supply/sc2731_charger.c       | 2 +-
>   drivers/power/supply/sc27xx_fuel_gauge.c    | 3 +--

> diff --git a/drivers/power/supply/sc2731_charger.c b/drivers/power/supply/sc2731_charger.c
> index 50d5157af9277dc09fe24852747f4f62e72bc712..58b86fd78771360f74ffdad152c3905e1bee7c1b 100644
> --- a/drivers/power/supply/sc2731_charger.c
> +++ b/drivers/power/supply/sc2731_charger.c
> @@ -480,7 +480,7 @@ static int sc2731_charger_probe(struct platform_device *pdev)
>   	}
>   
>   	charger_cfg.drv_data = info;
> -	charger_cfg.of_node = np;
> +	charger_cfg.fwnode = dev_fwnode(&pdev->dev);
>   	info->psy_usb = devm_power_supply_register(&pdev->dev,
>   						   &sc2731_charger_desc,
>   						   &charger_cfg);
> diff --git a/drivers/power/supply/sc27xx_fuel_gauge.c b/drivers/power/supply/sc27xx_fuel_gauge.c
> index f36edc2ba708748d0ceb61298056f8c905aca012..196d96cd986266738785d8582e907858faaf2ba3 100644
> --- a/drivers/power/supply/sc27xx_fuel_gauge.c
> +++ b/drivers/power/supply/sc27xx_fuel_gauge.c
> @@ -1141,7 +1141,6 @@ static int sc27xx_fgu_hw_init(struct sc27xx_fgu_data *data)
>   static int sc27xx_fgu_probe(struct platform_device *pdev)
>   {
>   	struct device *dev = &pdev->dev;
> -	struct device_node *np = dev->of_node;
>   	struct power_supply_config fgu_cfg = { };
>   	struct sc27xx_fgu_data *data;
>   	int ret, irq;
> @@ -1205,7 +1204,7 @@ static int sc27xx_fgu_probe(struct platform_device *pdev)
>   	platform_set_drvdata(pdev, data);
>   
>   	fgu_cfg.drv_data = data;
> -	fgu_cfg.of_node = np;
> +	fgu_cfg.fwnode = dev_fwnode(dev);
>   	data->battery = devm_power_supply_register(dev, &sc27xx_fgu_desc,
>   						   &fgu_cfg);
>   	if (IS_ERR(data->battery)) {

For sc27xx parts:

Acked-by: Baolin Wang <baolin.wang@...ux.alibaba.com>

Thanks.