| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1a444a2e-75b6-46f9-8f38-0458655873ac@zytor.com>
Date: Tue, 25 Feb 2025 09:10:01 -0800
From: Xin Li <xin@...or.com>
To: Borislav Petkov <bp@...en8.de>
Cc: linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
tglx@...utronix.de, mingo@...hat.com, dave.hansen@...ux.intel.com,
x86@...nel.org, hpa@...or.com, will@...nel.org, peterz@...radead.org,
yury.norov@...il.com, akpm@...ux-foundation.org, acme@...nel.org,
namhyung@...nel.org, brgerst@...il.com, andrew.cooper3@...rix.com,
nik.borisov@...e.com
Subject: Re: [PATCH v5 0/5] x86/cpufeatures: Automatically generate required
and disabled feature masks
On 2/23/2025 2:27 AM, Borislav Petkov wrote:
> On Sun, Jan 05, 2025 at 11:07:22PM -0800, Xin Li (Intel) wrote:
>> arch/x86/Kconfig | 4 +-
>> arch/x86/Kconfig.cpu | 12 +-
>> arch/x86/Kconfig.cpufeatures | 197 ++++++++++++++++++
>> arch/x86/Makefile | 17 +-
>> arch/x86/boot/cpucheck.c | 3 +-
>> arch/x86/boot/cpuflags.c | 1 -
>> arch/x86/boot/mkcpustr.c | 3 +-
>> arch/x86/include/asm/Kbuild | 1 +
>> arch/x86/include/asm/asm-prototypes.h | 2 +-
>> arch/x86/include/asm/atomic64_32.h | 2 +-
>> arch/x86/include/asm/bitops.h | 4 +-
>> arch/x86/include/asm/cmpxchg_32.h | 2 +-
>> arch/x86/include/asm/cpufeature.h | 71 +------
>> arch/x86/include/asm/cpufeatures.h | 13 +-
>> arch/x86/include/asm/disabled-features.h | 161 --------------
>> arch/x86/include/asm/required-features.h | 105 ----------
>> arch/x86/kernel/cpu/common.c | 1 +
>> arch/x86/kernel/verify_cpu.S | 4 +
>> arch/x86/lib/Makefile | 2 +-
>> arch/x86/lib/cmpxchg8b_emu.S | 2 +-
>> arch/x86/tools/featuremasks.awk | 88 ++++++++
>> lib/atomic64_test.c | 2 +-
>> tools/arch/x86/include/asm/cpufeatures.h | 8 -
>> .../arch/x86/include/asm/disabled-features.h | 161 --------------
>> .../arch/x86/include/asm/required-features.h | 105 ----------
>> tools/perf/check-headers.sh | 2 -
>> 26 files changed, 327 insertions(+), 646 deletions(-)
>> create mode 100644 arch/x86/Kconfig.cpufeatures
>> delete mode 100644 arch/x86/include/asm/disabled-features.h
>> delete mode 100644 arch/x86/include/asm/required-features.h
>> create mode 100755 arch/x86/tools/featuremasks.awk
>> delete mode 100644 tools/arch/x86/include/asm/disabled-features.h
>> delete mode 100644 tools/arch/x86/include/asm/required-features.h
>
> make --no-print-directory -C /home/kernel/linux \
> -f /home/kernel/linux/Makefile
> # GEN arch/x86/include/generated/asm/orc_hash.h
> mkdir -p arch/x86/include/generated/asm/; sh ./scripts/orc_hash.sh < arch/x86/include/asm/orc_types.h > arch/x86/include/generated/asm/orc_hash.h
> make -f ./scripts/Makefile.build obj=scripts/basic
> set -e; mkdir -p include/config/; trap "rm -f include/config/.tmp_kernel.release" EXIT; { ./scripts/setlocalversion .; } > include/config/.tmp_kernel.release; if [ ! -r include/config/kernel.release ] || ! cmp -s include/config/kernel.release include/config/.tmp_kernel.release; then : ' UPD include/config/kernel.release'; mv -f include/config/.tmp_kernel.release include/config/kernel.release; fi
> # GEN arch/x86/include/generated/asm/featuremasks.h
> awk -f ./arch/x86/tools/featuremasks.awk ./arch/x86/include/asm/cpufeatures.h .config > arch/x86/include/generated/asm/featuremasks.h
> make -f ./scripts/Makefile.asm-headers obj=arch/x86/include/generated/uapi/asm \
> generic=include/uapi/asm-generic
> awk: ./arch/x86/tools/featuremasks.awk: line 16: syntax error at or near {
> awk: ./arch/x86/tools/featuremasks.awk: line 20: syntax error at or near :
> awk: ./arch/x86/tools/featuremasks.awk: line 24: syntax error at or near }
> make[1]: *** [arch/x86/Makefile:285: arch/x86/include/generated/asm/featuremasks.h] Error 2
> make[1]: *** Deleting file 'arch/x86/include/generated/asm/featuremasks.h'
> make[1]: *** Waiting for unfinished jobs....
> # WRAP arch/x86/include/generated/uapi/asm/bpf_perf_event.h
> echo "#include <asm-generic/bpf_perf_event.h>" > arch/x86/include/generated/uapi/asm/bpf_perf_event.h
> # WRAP arch/x86/include/generated/uapi/asm/fcntl.h
> echo "#include <asm-generic/fcntl.h>" > arch/x86/include/generated/uapi/asm/fcntl.h
> # WRAP arch/x86/include/generated/uapi/asm/errno.h
> echo "#include <asm-generic/errno.h>" > arch/x86/include/generated/uapi/asm/errno.h
> # WRAP arch/x86/include/generated/uapi/asm/ioctl.h
> echo "#include <asm-generic/ioctl.h>" > arch/x86/include/generated/uapi/asm/ioctl.h
> # WRAP arch/x86/include/generated/uapi/asm/ioctls.h
> echo "#include <asm-generic/ioctls.h>" > arch/x86/include/generated/uapi/asm/ioctls.h
> # WRAP arch/x86/include/generated/uapi/asm/ipcbuf.h
> echo "#include <asm-generic/ipcbuf.h>" > arch/x86/include/generated/uapi/asm/ipcbuf.h
> # WRAP arch/x86/include/generated/uapi/asm/param.h
> echo "#include <asm-generic/param.h>" > arch/x86/include/generated/uapi/asm/param.h
> # WRAP arch/x86/include/generated/uapi/asm/poll.h
> echo "#include <asm-generic/poll.h>" > arch/x86/include/generated/uapi/asm/poll.h
> # WRAP arch/x86/include/generated/uapi/asm/resource.h
> echo "#include <asm-generic/resource.h>" > arch/x86/include/generated/uapi/asm/resource.h
> # WRAP arch/x86/include/generated/uapi/asm/socket.h
> echo "#include <asm-generic/socket.h>" > arch/x86/include/generated/uapi/asm/socket.h
> # WRAP arch/x86/include/generated/uapi/asm/sockios.h
> echo "#include <asm-generic/sockios.h>" > arch/x86/include/generated/uapi/asm/sockios.h
> # WRAP arch/x86/include/generated/uapi/asm/termbits.h
> echo "#include <asm-generic/termbits.h>" > arch/x86/include/generated/uapi/asm/termbits.h
> # WRAP arch/x86/include/generated/uapi/asm/termios.h
> echo "#include <asm-generic/termios.h>" > arch/x86/include/generated/uapi/asm/termios.h
> # WRAP arch/x86/include/generated/uapi/asm/types.h
> echo "#include <asm-generic/types.h>" > arch/x86/include/generated/uapi/asm/types.h
> make: *** [Makefile:251: __sub-make] Error 2
>
> Probably due to:
>
> $ awk --version
> mawk 1.3.4 20250131
> Copyright 2008-2024,2025, Thomas E. Dickey
> Copyright 1991-1996,2014, Michael D. Brennan
>
> random-funcs: srandom/random
> regex-funcs: internal
>
> compiled limits:
> sprintf buffer 8192
> maximum-integer 9223372036854775808
>
> while the other box has GNU awk where it obviously works.
After looking into the build issue, we think it's better to change to
perl; GNU awk has quite a few extended features that standard awk
doesn't support, e.g., BEGINFILE/FPAT/...
Thanks!
Xin
>
> HTH.
>
Powered by blists - more mailing lists