linux-kernel - Re: [PATCH 3/3] perf list: Document -v option deduplication feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fVEQvP7viecoGzLyUv1_Dsx6FhvmrYakWgi_TrBXPGSiw@mail.gmail.com>
Date: Tue, 25 Feb 2025 09:22:54 -0800
From: Ian Rogers <irogers@...gle.com>
To: James Clark <james.clark@...aro.org>
Cc: linux-perf-users@...r.kernel.org, namhyung@...nel.org, cyy@...self.name, 
	Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
	Arnaldo Carvalho de Melo <acme@...nel.org>, Mark Rutland <mark.rutland@....com>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, 
	Adrian Hunter <adrian.hunter@...el.com>, "Liang, Kan" <kan.liang@...ux.intel.com>, 
	Yoshihiro Furudera <fj5100bi@...itsu.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Weilin Wang <weilin.wang@...el.com>, Junhao He <hejunhao3@...wei.com>, 
	Jean-Philippe Romain <jean-philippe.romain@...s.st.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] perf list: Document -v option deduplication feature

On Tue, Feb 25, 2025 at 8:47 AM James Clark <james.clark@...aro.org> wrote:
>
> -v disables deduplication of similarly suffixed PMUs so add it to the
> help and doc strings.
>
> Signed-off-by: James Clark <james.clark@...aro.org>

Reviewed-by: Ian Rogers <irogers@...gle.com>

Thanks,
Ian


> ---
>  tools/perf/Documentation/perf-list.txt | 2 +-
>  tools/perf/builtin-list.c              | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/Documentation/perf-list.txt b/tools/perf/Documentation/perf-list.txt
> index c3ffd93f94d7..8914f12d2b85 100644
> --- a/tools/perf/Documentation/perf-list.txt
> +++ b/tools/perf/Documentation/perf-list.txt
> @@ -27,7 +27,7 @@ Don't print descriptions.
>
>  -v::
>  --long-desc::
> -Print longer event descriptions.
> +Print longer event descriptions and all similar PMUs with alphanumeric suffixes.
>
>  --debug::
>  Enable debugging output.
> diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c
> index c19826f218a0..fed482adb039 100644
> --- a/tools/perf/builtin-list.c
> +++ b/tools/perf/builtin-list.c
> @@ -527,7 +527,7 @@ int cmd_list(int argc, const char **argv)
>                 OPT_BOOLEAN('d', "desc", &default_ps.desc,
>                             "Print extra event descriptions. --no-desc to not print."),
>                 OPT_BOOLEAN('v', "long-desc", &default_ps.long_desc,
> -                           "Print longer event descriptions."),
> +                           "Print longer event descriptions and all similar PMUs with alphanumeric suffixes."),
>                 OPT_BOOLEAN(0, "details", &default_ps.detailed,
>                             "Print information on the perf event names and expressions used internally by events."),
>                 OPT_STRING('o', "output", &output_path, "file", "output file name"),
> --
> 2.34.1
>