linux-kernel - Re: [PATCH] rtc: fsl-ftm: remove incorrect ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <171c5e1c-5526-4846-aa50-fe2d49fb7f7f@kernel.org>
Date: Tue, 25 Feb 2025 18:26:36 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc: Arnd Bergmann <arnd@...nel.org>, Arnd Bergmann <arnd@...db.de>,
 linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: fsl-ftm: remove incorrect ACPI_PTR annotation

On 25/02/2025 18:16, Alexandre Belloni wrote:
> On 25/02/2025 18:12:10+0100, Krzysztof Kozlowski wrote:
>> On 25/02/2025 17:34, Arnd Bergmann wrote:
>>> From: Arnd Bergmann <arnd@...db.de>
>>>
>>> Building with W=1 shows a warning about ftm_imx_acpi_ids being unused when
>>> CONFIG_ACPI is disabled:
>>>
>>> drivers/rtc/rtc-fsl-ftm-alarm.c:312:36: error: unused variable 'ftm_imx_acpi_ids' [-Werror,-Wunused-const-variable]
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>>
>> I already sent a fix for this few days ago:
>>
>> https://lore.kernel.org/all/20250222114146.162835-1-krzysztof.kozlowski@linaro.org/
>>
> 
> But wouldn't Arnd's one be better?

ACPI table can be here entirely dropped and driver will match via
PRP0001, so I think ACPI_PTR makes sense.

But if you have arguments for keeping both, sure... There was no
response to my trivial patch and multiple people will be wasting same
time on the same issue. So just apply whichever of these, before third
person wastes more time on that warning.

Best regards,
Krzysztof