linux-kernel - Re: [PATCH sched_ext/for-6.14-fixes] sched_ext: Fix pick_task_scx() picking non-queued tasks when it's called without balance()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z74Bo8PEbDLiQYWm@slm.duckdns.org>
Date: Tue, 25 Feb 2025 07:45:07 -1000
From: Tejun Heo <tj@...nel.org>
To: Andrea Righi <arighi@...dia.com>
Cc: David Vernet <void@...ifault.com>, Changwoo Min <changwoo@...lia.com>,
	linux-kernel@...r.kernel.org, sched-ext@...a.com
Subject: Re: [PATCH sched_ext/for-6.14-fixes] sched_ext: Fix pick_task_scx()
 picking non-queued tasks when it's called without balance()

On Tue, Feb 25, 2025 at 06:14:15PM +0100, Andrea Righi wrote:
> > Fix it by testing whether @prev has SCX_TASK_QUEUED set. This makes
> > $prev_on_scx only used in one place. Open code the usage and improve the
> 
> nit: @prev_on_scx?

Yeah, I don't know. Some people use @ only for arguments and $ for
variables. Others always use @. I flip flop between them.

Thanks.

-- 
tejun