| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAP-5=fU8Xw-aeCGUOFo8Zph=xagHv43jo+BkXY5vUai5tUsmDA@mail.gmail.com>
Date: Mon, 24 Feb 2025 20:37:01 -0800
From: Ian Rogers <irogers@...gle.com>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>, Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>,
Adrian Hunter <adrian.hunter@...el.com>, Kan Liang <kan.liang@...ux.intel.com>,
John Garry <john.g.garry@...cle.com>, Will Deacon <will@...nel.org>,
James Clark <james.clark@...aro.org>, Mike Leach <mike.leach@...aro.org>,
Leo Yan <leo.yan@...ux.dev>, guoren <guoren@...nel.org>,
Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>, Charlie Jenkins <charlie@...osinc.com>,
Bibo Mao <maobibo@...ngson.cn>, Huacai Chen <chenhuacai@...nel.org>,
Catalin Marinas <catalin.marinas@....com>, Jiri Slaby <jirislaby@...nel.org>,
Björn Töpel <bjorn@...osinc.com>,
Howard Chu <howardchu95@...il.com>, linux-kernel@...r.kernel.org,
linux-perf-users@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
"linux-csky@...r.kernel.org" <linux-csky@...r.kernel.org>, linux-riscv@...ts.infradead.org,
linux-mips@...r.kernel.org, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v3 0/8] perf: Support multiple system call tables in the build
On Mon, Feb 24, 2025 at 7:05 PM Namhyung Kim <namhyung@...nel.org> wrote:
>
> On Wed, Feb 19, 2025 at 10:56:49AM -0800, Ian Rogers wrote:
> > This work builds on the clean up of system call tables and removal of
> > libaudit by Charlie Jenkins <charlie@...osinc.com>.
> >
> > The system call table in perf trace is used to map system call numbers
> > to names and vice versa. Prior to these changes, a single table
> > matching the perf binary's build was present. The table would be
> > incorrect if tracing say a 32-bit binary from a 64-bit version of
> > perf, the names and numbers wouldn't match.
> >
> > Change the build so that a single system call file is built and the
> > potentially multiple tables are identifiable from the ELF machine type
> > of the process being examined. To determine the ELF machine type, the
> > executable's header is read from /proc/pid/exe with fallbacks to using
> > the perf's binary type when unknown.
> >
> > Remove some runtime types used by the system call tables and make
> > equivalents generated at build time.
>
> So I tested this with a test program.
>
> $ cat a.c
> #include <stdio.h>
> int main(void)
> {
> char buf[4096];
> FILE *fp = fopen("a.c", "r");
> size_t len;
>
> len = fread(buf, sizeof(buf), 1, fp);
> fwrite(buf, 1, len, stdout);
> fflush(stdout);
> fclose(fp);
> return 0;
> }
>
> $ gcc -o a64.out a.c
> $ gcc -o a32.out -m32 a.c
>
> $ ./perf version
> perf version 6.14.rc1.ge002a64f6188
>
> $ git show
> commit e002a64f61882626992dd6513c0db3711c06fea7 (HEAD -> perf-check)
> Author: Ian Rogers <irogers@...gle.com>
> Date: Wed Feb 19 10:56:57 2025 -0800
>
> perf syscalltbl: Mask off ABI type for MIPS system calls
>
> Arnd Bergmann described that MIPS system calls don't necessarily start
> from 0 as an ABI prefix is applied:
> https://lore.kernel.org/lkml/8ed7dfb2-1e4d-4aa4-a04b-0397a89365d1@app.fastmail.com/
> When decoding the "id" (aka system call number) for MIPS ignore values
> greater-than 1000.
>
> Signed-off-by: Ian Rogers <irogers@...gle.com>
>
> It works well with 64bit.
>
> $ sudo ./perf trace ./a64.out |& tail
> 0.266 ( 0.007 ms): a64.out/858681 munmap(addr: 0x7f392723a000, len: 109058) = 0
> 0.286 ( 0.002 ms): a64.out/858681 getrandom(ubuf: 0x7f3927232178, len: 8, flags: NONBLOCK) = 8
> 0.289 ( 0.001 ms): a64.out/858681 brk() = 0x56419ecf7000
> 0.291 ( 0.002 ms): a64.out/858681 brk(brk: 0x56419ed18000) = 0x56419ed18000
> 0.299 ( 0.009 ms): a64.out/858681 openat(dfd: CWD, filename: "a.c") = 3
> 0.312 ( 0.001 ms): a64.out/858681 fstat(fd: 3, statbuf: 0x7ffdfadf1eb0) = 0
> 0.315 ( 0.002 ms): a64.out/858681 read(fd: 3, buf: 0x7ffdfadf2030, count: 4096) = 211
> 0.318 ( 0.009 ms): a64.out/858681 read(fd: 3, buf: 0x56419ecf7480, count: 4096) = 0
> 0.330 ( 0.001 ms): a64.out/858681 close(fd: 3) = 0
> 0.338 ( ): a64.out/858681 exit_group() = ?
>
> But 32bit is still broken and use 64bit syscall table wrongly.
>
> $ file a32.out
> a32.out: ELF 32-bit LSB pie executable, Intel 80386, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux.so.2,
> BuildID[sha1]=6eea873c939012e6c715e8f030261642bf61cb4e, for GNU/Linux 3.2.0, not stripped
>
> $ sudo ./perf trace ./a32.out |& tail
> 0.296 ( 0.001 ms): a32.out/858699 getxattr(pathname: "", name: "������", value: 0xf7f6ce14, size: 1) = 0
> 0.305 ( 0.007 ms): a32.out/858699 fchmod(fd: -134774784, mode: IFLNK|ISUID|ISVTX|IWOTH|0x10000) = 0
> 0.333 ( 0.001 ms): a32.out/858699 recvfrom(size: 4160146964, flags: RST|0x20000, addr: 0xf7f6ce14, addr_len: 0xf7f71278) = 1481879552
> 0.335 ( 0.004 ms): a32.out/858699 recvfrom(fd: 1482014720, ubuf: 0xf7f71278, size: 4160146964, flags: NOSIGNAL|MORE|WAITFORONE|BATCH|SPLICE_PAGES|CMSG_CLOEXEC|0x10500000, addr: 0xf7f6ce14, addr_len: 0xf7f71278) = 1482014720
> 0.355 ( 0.002 ms): a32.out/858699 recvfrom(fd: 1482018816, ubuf: 0x5855d000, size: 4160146964, flags: RST|NOSIGNAL|MORE|WAITFORONE|BATCH|SPLICE_PAGES|CMSG_CLOEXEC|0x10500000, addr: 0xf7f6ce14, addr_len: 0xf7f71278) = 1482018816
> 0.362 ( 0.010 ms): a32.out/858699 preadv(fd: 4294967196, vec: (struct iovec){.iov_base = (void *)0x1b01000000632e62,.iov_len = (__kernel_size_t)1125899909479171,}, pos_h: 4160146964) = 3
> 0.385 ( 0.002 ms): a32.out/858699 close(fd: 3) = 211
> 0.388 ( 0.001 ms): a32.out/858699 close(fd: 3) = 0
> 0.393 ( 0.002 ms): a32.out/858699 lstat(filename: "") = 0
> 0.396 ( 0.004 ms): a32.out/858699 recvfrom(fd: 1482014720, size: 4160146964, flags: NOSIGNAL|MORE|WAITFORONE|BATCH|SPLICE_PAGES|CMSG_CLOEXEC|0x10500000, addr: 0xf7f6ce14, addr_len: 0xf7f71278) = 1482014720
>
> The last 5 should be openat, read, read, close and brk(?).
That's strange as nearly the same test works for me:
```
$ git show
commit 7920020237af8138f7be1a21be9a2918a71ddc5e (HEAD -> ptn-syscalltbl)
Author: Ian Rogers <irogers@...gle.com>
Date: Fri Jan 31 21:34:07 2025 -0800
perf syscalltbl: Mask off ABI type for MIPS system calls
Arnd Bergmann described that MIPS system calls don't necessarily start
from 0 as an ABI prefix is applied:
https://lore.kernel.org/lkml/8ed7dfb2-1e4d-4aa4-a04b-0397a89365d1@app.fastmail.com/
When decoding the "id" (aka system call number) for MIPS ignore values
greater-than 1000.
Signed-off-by: Ian Rogers <irogers@...gle.com>
..
$ file a.out
a.out: ELF 32-bit LSB pie executable, Intel 80386, version 1 (SYSV),
dynamically linked, interpreter /lib/ld-linux.so.2,
BuildID[sha1]=3fcd28f85a27a3108941661a91dbc675c06868f9, for GNU/Linux
3.2.0, not stripped
$ sudo /tmp/perf/perf trace ./a.out
...
? ( ): a.out/218604 ... [continued]: execve())
= 0
0.067 ( 0.003 ms): a.out/218604 brk()
= 0x5749e000
0.154 ( 0.007 ms): a.out/218604 access(filename: 0xf7fc7f28,
mode: R) = -1 ENOENT (No such file or
directory)
0.168 ( 0.023 ms): a.out/218604 openat(dfd: CWD, filename:
0xf7fc44c3, flags: RDONLY|CLOEXEC|LARGEFILE) = 3
0.193 ( 0.006 ms): a.out/218604 statx(dfd:
3</proc/218604/status>, filename: 0xf7fc510a, flags:
NO_AUTOMOUNT|EMPTY_PATH, mask:
TYPE|MODE|NLINK|UID|GID|ATIME|MTIME|CTIME|INO|SIZE|BLOCKS, buffer:
0xffaa6b88) = 0
0.212 ( 0.002 ms): a.out/218604 close(fd: 3</proc/218604/status>)
= 0
0.233 ( 0.019 ms): a.out/218604 openat(dfd: CWD, filename:
0xf7f973e0, flags: RDONLY|CLOEXEC|LARGEFILE) = 3
0.255 ( 0.004 ms): a.out/218604 read(fd: 3</proc/218604/status>,
buf: 0xffaa6df0, count: 512) = 512
0.262 ( 0.003 ms): a.out/218604 statx(dfd:
3</proc/218604/status>, filename: 0xf7fc510a, flags:
NO_AUTOMOUNT|EMPTY_PATH, mask:
TYPE|MODE|NLINK|UID|GID|ATIME|MTIME|CTIME|INO|SIZE|BLOCKS, buffer:
0xffaa6b38) = 0
0.347 ( 0.002 ms): a.out/218604 close(fd: 3</proc/218604/status>)
= 0
0.372 ( 0.002 ms): a.out/218604 set_tid_address(tidptr:
0xf7f98528) = 218604 (a.out)
0.376 ( 0.002 ms): a.out/218604 set_robust_list(head: 0xf7f9852c,
len: 12) =
0.381 ( 0.002 ms): a.out/218604 rseq(rseq: 0xf7f98960, rseq_len:
32, sig: 1392848979) =
0.469 ( 0.010 ms): a.out/218604 mprotect(start: 0xf7f6e000, len:
8192, prot: READ) = 0
0.489 ( 0.007 ms): a.out/218604 mprotect(start: 0x5661a000, len:
4096, prot: READ) = 0
0.503 ( 0.007 ms): a.out/218604 mprotect(start: 0xf7fd0000, len:
8192, prot: READ) = 0
0.550 ( 0.015 ms): a.out/218604 munmap(addr: 0xf7f7b000, len:
111198) = 0
0.589 ( 0.035 ms): a.out/218604 openat(dfd: CWD, filename:
0x56619008) = 3
0.627 ( 0.024 ms): a.out/218604 read(fd: 3</proc/218604/status>,
buf: 0xffaa68fc, count: 4096) = 1437
0.654 ( 0.090 ms): a.out/218604 write(fd: 1</dev/pts/3>, buf: ,
count: 1437) = 1437
0.766 (1000.164 ms): a.out/218604 clock_nanosleep(rqtp:
0xffaa6824, rmtp: 0xffaa681c) = 0
1000.942 ( ): a.out/218604 exit_group()
$ file /tmp/perf/perf
/tmp/perf/perf: ELF 64-bit LSB pie executable, x86-64, version 1
(SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2,
BuildID[sha1]=60b07f65d2559a7193b2d1d36cfa00054dfbd076, for GNU/Linux
3.2.0, with debug_info, not stripped
```
Perhaps your a.out binary was built as an x32 one?
Looking under the covers with gdb:
```
$ sudo gdb --args /tmp/perf/perf trace ./a.out
GNU gdb (Debian 15.1-1) 15.1
...
Reading symbols from /tmp/perf/perf...
(gdb) b syscalltbl__name
Breakpoint 1 at 0x23a51b: file util/syscalltbl.c, line 47.
(gdb) r
...
[Detaching after vfork from child process 218826]
Breakpoint 1, syscalltbl__name (e_machine=3, id=11) at util/syscalltbl.c:47
47 const struct syscalltbl *table = find_table(e_machine);
```
So the e_machine is 3 which corresponds to EM_386.
I've not fixed every use of syscalltbl but I believe this one is working.
Thanks,
Ian
> >
> > v3: Add Charlie's reviewed-by tags. Incorporate feedback from Arnd
> > Bergmann <arnd@...db.de> on additional optional column and MIPS
> > system call numbering. Rebase past Namhyung's global system call
> > statistics and add comments that they don't yet support an
> > e_machine other than EM_HOST.
> >
> > v2: Change the 1 element cache for the last table as suggested by
> > Howard Chu, add Howard's reviewed-by tags.
> > Add a comment and apology to Charlie for not doing better in
> > guiding:
> > https://lore.kernel.org/all/20250114-perf_syscall_arch_runtime-v1-1-5b304e408e11@rivosinc.com/
> > After discussion on v1 and he agreed this patch series would be
> > the better direction.
> >
> > Ian Rogers (8):
> > perf syscalltble: Remove syscall_table.h
> > perf trace: Reorganize syscalls
> > perf syscalltbl: Remove struct syscalltbl
> > perf thread: Add support for reading the e_machine type for a thread
> > perf trace beauty: Add syscalltbl.sh generating all system call tables
> > perf syscalltbl: Use lookup table containing multiple architectures
> > perf build: Remove Makefile.syscalls
> > perf syscalltbl: Mask off ABI type for MIPS system calls
> >
> > tools/perf/Makefile.perf | 10 +-
> > tools/perf/arch/alpha/entry/syscalls/Kbuild | 2 -
> > .../alpha/entry/syscalls/Makefile.syscalls | 5 -
> > tools/perf/arch/alpha/include/syscall_table.h | 2 -
> > tools/perf/arch/arc/entry/syscalls/Kbuild | 2 -
> > .../arch/arc/entry/syscalls/Makefile.syscalls | 3 -
> > tools/perf/arch/arc/include/syscall_table.h | 2 -
> > tools/perf/arch/arm/entry/syscalls/Kbuild | 4 -
> > .../arch/arm/entry/syscalls/Makefile.syscalls | 2 -
> > tools/perf/arch/arm/include/syscall_table.h | 2 -
> > tools/perf/arch/arm64/entry/syscalls/Kbuild | 3 -
> > .../arm64/entry/syscalls/Makefile.syscalls | 6 -
> > tools/perf/arch/arm64/include/syscall_table.h | 8 -
> > tools/perf/arch/csky/entry/syscalls/Kbuild | 2 -
> > .../csky/entry/syscalls/Makefile.syscalls | 3 -
> > tools/perf/arch/csky/include/syscall_table.h | 2 -
> > .../perf/arch/loongarch/entry/syscalls/Kbuild | 2 -
> > .../entry/syscalls/Makefile.syscalls | 3 -
> > .../arch/loongarch/include/syscall_table.h | 2 -
> > tools/perf/arch/mips/entry/syscalls/Kbuild | 2 -
> > .../mips/entry/syscalls/Makefile.syscalls | 5 -
> > tools/perf/arch/mips/include/syscall_table.h | 2 -
> > tools/perf/arch/parisc/entry/syscalls/Kbuild | 3 -
> > .../parisc/entry/syscalls/Makefile.syscalls | 6 -
> > .../perf/arch/parisc/include/syscall_table.h | 8 -
> > tools/perf/arch/powerpc/entry/syscalls/Kbuild | 3 -
> > .../powerpc/entry/syscalls/Makefile.syscalls | 6 -
> > .../perf/arch/powerpc/include/syscall_table.h | 8 -
> > tools/perf/arch/riscv/entry/syscalls/Kbuild | 2 -
> > .../riscv/entry/syscalls/Makefile.syscalls | 4 -
> > tools/perf/arch/riscv/include/syscall_table.h | 8 -
> > tools/perf/arch/s390/entry/syscalls/Kbuild | 2 -
> > .../s390/entry/syscalls/Makefile.syscalls | 5 -
> > tools/perf/arch/s390/include/syscall_table.h | 2 -
> > tools/perf/arch/sh/entry/syscalls/Kbuild | 2 -
> > .../arch/sh/entry/syscalls/Makefile.syscalls | 4 -
> > tools/perf/arch/sh/include/syscall_table.h | 2 -
> > tools/perf/arch/sparc/entry/syscalls/Kbuild | 3 -
> > .../sparc/entry/syscalls/Makefile.syscalls | 5 -
> > tools/perf/arch/sparc/include/syscall_table.h | 8 -
> > tools/perf/arch/x86/entry/syscalls/Kbuild | 3 -
> > .../arch/x86/entry/syscalls/Makefile.syscalls | 6 -
> > tools/perf/arch/x86/include/syscall_table.h | 8 -
> > tools/perf/arch/xtensa/entry/syscalls/Kbuild | 2 -
> > .../xtensa/entry/syscalls/Makefile.syscalls | 4 -
> > .../perf/arch/xtensa/include/syscall_table.h | 2 -
> > tools/perf/builtin-trace.c | 290 +++++++++++-------
> > tools/perf/scripts/Makefile.syscalls | 61 ----
> > tools/perf/scripts/syscalltbl.sh | 86 ------
> > tools/perf/trace/beauty/syscalltbl.sh | 274 +++++++++++++++++
> > tools/perf/util/syscalltbl.c | 148 ++++-----
> > tools/perf/util/syscalltbl.h | 22 +-
> > tools/perf/util/thread.c | 50 +++
> > tools/perf/util/thread.h | 14 +-
> > 54 files changed, 616 insertions(+), 509 deletions(-)
> > delete mode 100644 tools/perf/arch/alpha/entry/syscalls/Kbuild
> > delete mode 100644 tools/perf/arch/alpha/entry/syscalls/Makefile.syscalls
> > delete mode 100644 tools/perf/arch/alpha/include/syscall_table.h
> > delete mode 100644 tools/perf/arch/arc/entry/syscalls/Kbuild
> > delete mode 100644 tools/perf/arch/arc/entry/syscalls/Makefile.syscalls
> > delete mode 100644 tools/perf/arch/arc/include/syscall_table.h
> > delete mode 100644 tools/perf/arch/arm/entry/syscalls/Kbuild
> > delete mode 100644 tools/perf/arch/arm/entry/syscalls/Makefile.syscalls
> > delete mode 100644 tools/perf/arch/arm/include/syscall_table.h
> > delete mode 100644 tools/perf/arch/arm64/entry/syscalls/Kbuild
> > delete mode 100644 tools/perf/arch/arm64/entry/syscalls/Makefile.syscalls
> > delete mode 100644 tools/perf/arch/arm64/include/syscall_table.h
> > delete mode 100644 tools/perf/arch/csky/entry/syscalls/Kbuild
> > delete mode 100644 tools/perf/arch/csky/entry/syscalls/Makefile.syscalls
> > delete mode 100644 tools/perf/arch/csky/include/syscall_table.h
> > delete mode 100644 tools/perf/arch/loongarch/entry/syscalls/Kbuild
> > delete mode 100644 tools/perf/arch/loongarch/entry/syscalls/Makefile.syscalls
> > delete mode 100644 tools/perf/arch/loongarch/include/syscall_table.h
> > delete mode 100644 tools/perf/arch/mips/entry/syscalls/Kbuild
> > delete mode 100644 tools/perf/arch/mips/entry/syscalls/Makefile.syscalls
> > delete mode 100644 tools/perf/arch/mips/include/syscall_table.h
> > delete mode 100644 tools/perf/arch/parisc/entry/syscalls/Kbuild
> > delete mode 100644 tools/perf/arch/parisc/entry/syscalls/Makefile.syscalls
> > delete mode 100644 tools/perf/arch/parisc/include/syscall_table.h
> > delete mode 100644 tools/perf/arch/powerpc/entry/syscalls/Kbuild
> > delete mode 100644 tools/perf/arch/powerpc/entry/syscalls/Makefile.syscalls
> > delete mode 100644 tools/perf/arch/powerpc/include/syscall_table.h
> > delete mode 100644 tools/perf/arch/riscv/entry/syscalls/Kbuild
> > delete mode 100644 tools/perf/arch/riscv/entry/syscalls/Makefile.syscalls
> > delete mode 100644 tools/perf/arch/riscv/include/syscall_table.h
> > delete mode 100644 tools/perf/arch/s390/entry/syscalls/Kbuild
> > delete mode 100644 tools/perf/arch/s390/entry/syscalls/Makefile.syscalls
> > delete mode 100644 tools/perf/arch/s390/include/syscall_table.h
> > delete mode 100644 tools/perf/arch/sh/entry/syscalls/Kbuild
> > delete mode 100644 tools/perf/arch/sh/entry/syscalls/Makefile.syscalls
> > delete mode 100644 tools/perf/arch/sh/include/syscall_table.h
> > delete mode 100644 tools/perf/arch/sparc/entry/syscalls/Kbuild
> > delete mode 100644 tools/perf/arch/sparc/entry/syscalls/Makefile.syscalls
> > delete mode 100644 tools/perf/arch/sparc/include/syscall_table.h
> > delete mode 100644 tools/perf/arch/x86/entry/syscalls/Kbuild
> > delete mode 100644 tools/perf/arch/x86/entry/syscalls/Makefile.syscalls
> > delete mode 100644 tools/perf/arch/x86/include/syscall_table.h
> > delete mode 100644 tools/perf/arch/xtensa/entry/syscalls/Kbuild
> > delete mode 100644 tools/perf/arch/xtensa/entry/syscalls/Makefile.syscalls
> > delete mode 100644 tools/perf/arch/xtensa/include/syscall_table.h
> > delete mode 100644 tools/perf/scripts/Makefile.syscalls
> > delete mode 100755 tools/perf/scripts/syscalltbl.sh
> > create mode 100755 tools/perf/trace/beauty/syscalltbl.sh
> >
> > --
> > 2.48.1.601.g30ceb7b040-goog
> >
Powered by blists - more mailing lists