linux-kernel - Re: [PATCH] [RESEND] Input: synaptics: hide unused smbus_pnp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z74vPf6-qETZG0t1@google.com>
Date: Tue, 25 Feb 2025 12:59:41 -0800
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Benjamin Tissoires <bentiss@...nel.org>, Arnd Bergmann <arnd@...db.de>,
	Takashi Iwai <tiwai@...e.de>, Jonathan Denose <jdenose@...gle.com>,
	Erick Archer <erick.archer@...look.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [RESEND] Input: synaptics: hide unused smbus_pnp_ids[]
 array

On Tue, Feb 25, 2025 at 03:54:38PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> When SMBUS is disabled, this is never referenced, causing a W=1 warning:
> 
> drivers/input/mouse/synaptics.c:164:27: error: 'smbus_pnp_ids' defined but not used [-Werror=unused-const-variable=]
> 
> Hide the array behind the same #ifdef as the code referencing it.
> 
> Fixes: e839ffab0289 ("Input: synaptics - add support for Intertouch devices")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thank you.

-- 
Dmitry