linux-kernel - Re: [PATCH 7/7] power: supply: core: convert to fwnnode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <duzge5bpxv4cd7b27pq2daisqtaw6mtt6oxl2u3hcdxcnh5tkw@yasxlx33yxbi>
Date: Tue, 25 Feb 2025 22:22:42 +0100
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Hans de Goede <hdegoede@...hat.com>
Cc: Mark Brown <broonie@...nel.org>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Linus Walleij <linus.walleij@...aro.org>, 
	Liam Girdwood <lgirdwood@...il.com>, Chen-Yu Tsai <wens@...e.org>, 
	Matti Vaittinen <mazziesaccount@...il.com>, Pali Rohár <pali@...nel.org>, 
	Paul Cercueil <paul@...pouillou.net>, Samuel Holland <samuel@...lland.org>, 
	David Lechner <david@...hnology.com>, Krzysztof Kozlowski <krzk@...nel.org>, 
	Marek Szyprowski <m.szyprowski@...sung.com>, Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>, 
	Purism Kernel Team <kernel@...i.sm>, Bartosz Golaszewski <brgl@...ev.pl>, 
	Konrad Dybcio <konradybcio@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Orson Zhai <orsonzhai@...il.com>, 
	Baolin Wang <baolin.wang@...ux.alibaba.com>, Chunyan Zhang <zhang.lyra@...il.com>, linux-pm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH 7/7] power: supply: core: convert to fwnnode

Hello Hans,

On Tue, Feb 25, 2025 at 02:16:12PM +0100, Hans de Goede wrote:
> Hi Sebastian,
> 
> Thank you for your work on this.
>
> A few small remarks inline / below.
> 
> On 25-Feb-25 12:21 AM, Sebastian Reichel wrote:
> 
> <snip>
> 
> > diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
> > index a785742f97721e7e70d0e4c17a1ded7b985acb6d..9afde8c04efc72691c81a373d8dd03477b4efd7e 100644
> > --- a/include/linux/power_supply.h
> > +++ b/include/linux/power_supply.h
> > @@ -805,7 +805,7 @@ static inline struct power_supply *power_supply_get_by_name(const char *name)
> >  { return NULL; }
> >  #endif
> >  #ifdef CONFIG_OF
> > -extern struct power_supply *power_supply_get_by_phandle(struct device_node *np,
> > +extern struct power_supply *power_supply_get_by_phandle(struct fwnode_handle *fwnode,
> >  							const char *property);
> 
> this function now no longer is DT/OF/open-firmware specific, so I think it should be moved
> outside of the #ifdef CONFIG_OF block now ?  The same goes for the devm variant I think
> and the implementations of course also should no longer be "#ifdef CONFIG_OF".

Good point. I suppose ideally the name should also change to power_supply_get_by_reference,
since phandle is a DT/OF term. I will prepare these two changes for v2.

Greetings,

-- Sebastian

> >  extern struct power_supply *devm_power_supply_get_by_phandle(
> >  				    struct device *dev, const char *property);
> 
> Regards,
> 
> Hans
> 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)