linux-kernel - [PATCH] pinctrl / gpio bcm2835

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CANVomh-u7pvk69FTfSbYGSoq5ZVnVMeDW3wQBYWUx4XPq64mmA@mail.gmail.com>
Date: Tue, 25 Feb 2025 21:40:46 +0000
From: C Larbi <pkl2000us@...il.com>
To: linux-kernel@...r.kernel.org
Subject: [PATCH] pinctrl / gpio bcm2835

A patch to remove redundant call to gpiochip_remove().
I am a beginner, and this line of code really confused me as i was
expecting an initial call to gpiochip_add_data()

>From 675aac08dbd0c20c43ab8def39141c33b06cd7ba Mon Sep 17 00:00:00 2001
From: cerezo <cerezo.larbi@...look.com>
Date: Tue, 25 Feb 2025 20:30:13 +0000
Subject: [PATCH] Remove unneccesary call to gpiochip_remove

---
 drivers/pinctrl/bcm/pinctrl-bcm2835.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c
b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
index cc1fe0555e19..5e31a5704fcc 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
@@ -1348,7 +1348,6 @@ static int bcm2835_pinctrl_probe(struct
platform_device *pdev)
  pc->pctl_desc = *pdata->pctl_desc;
  pc->pctl_dev = devm_pinctrl_register(dev, &pc->pctl_desc, pc);
  if (IS_ERR(pc->pctl_dev)) {
- gpiochip_remove(&pc->gpio_chip);
  return PTR_ERR(pc->pctl_dev);
  }