linux-kernel - Re: [PATCH] crypto: lib/Kconfig - fix chacha/poly1305 dependencies more more

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <c4896a12-8abe-4fe6-b381-86b23d32b332@app.fastmail.com>
Date: Tue, 25 Feb 2025 22:50:10 +0100
From: "Arnd Bergmann" <arnd@...nel.org>
To: "Arnd Bergmann" <arnd@...db.de>, "Will Deacon" <will@...nel.org>
Cc: "Herbert Xu" <herbert@...dor.apana.org.au>,
 "David S . Miller" <davem@...emloft.net>,
 "Catalin Marinas" <catalin.marinas@....com>,
 "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>,
 "Harald Freudenberger" <freude@...ux.ibm.com>,
 "Holger Dengler" <dengler@...ux.ibm.com>,
 "Heiko Carstens" <hca@...ux.ibm.com>, "Vasily Gorbik" <gor@...ux.ibm.com>,
 "Alexander Gordeev" <agordeev@...ux.ibm.com>,
 "Christian Borntraeger" <borntraeger@...ux.ibm.com>,
 "Sven Schnelle" <svens@...ux.ibm.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 "Ard Biesheuvel" <ardb@...nel.org>, "Eric Biggers" <ebiggers@...gle.com>,
 "James E . J . Bottomley" <James.Bottomley@...senpartnership.com>,
 "Jarkko Sakkinen" <jarkko@...nel.org>, linux-crypto@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-mips@...r.kernel.org, linux-s390@...r.kernel.org
Subject: Re: [PATCH] crypto: lib/Kconfig - fix chacha/poly1305 dependencies more more

On Tue, Feb 25, 2025, at 22:40, Arnd Bergmann wrote:
> On Tue, Feb 25, 2025, at 22:33, Will Deacon wrote:
>> On Tue, Feb 25, 2025 at 05:42:07PM +0100, Arnd Bergmann wrote:
>>> From: Arnd Bergmann <arnd@...db.de>
>>> 
>>> A recent change tries to fix Kconfig dependencies, but introduced
>>> two problems in the process:
>>> 
>>>  - only arm, powerpc and x86 are changed, while mips, arm64 and s390
>>>    are now broken
>>> 
>>>  - there are now configurations where the architecture enables its
>>>    own helper functions as loadable modules, but they remain silently
>>>    unused because CRYPTO_LIB_* falls back to the generic helpers
>>> 
>>> Address both by changing the logic again: the architecture functions
>>> select CRYPTO_ARCH_MAY_HAVE_LIB_CHACHA, which may be a loadable
>>> module or built-in, and this controls whether the library is
>>> also built-in.
>>> 
>>> Fixes: 04f9ccc955c7 ("crypto: lib/Kconfig - Fix lib built-in failure when arch is modular")
>>
>> Which tree contains this change? I can't seem to resolve the SHA locally.
>
> Sorry, that must have been an older commit ID. Today's linux-next
> contains 56b8e4bb7622 ("crypto: lib/Kconfig - Fix lib built-in failure
> when arch is modular")
>
> which is in
> git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git

After looking at the original 0day report, I think the fix for
that problem would have been

--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -94,6 +94,7 @@ config WIREGUARD
        select CRYPTO_CHACHA_MIPS if CPU_MIPS32_R2
        select CRYPTO_POLY1305_MIPS if MIPS
        select CRYPTO_CHACHA_S390 if S390
+       select CRYPTO_CURVE25519_PPC64 if PPC64 && CPU_LITTLE_ENDIAN
        help
          WireGuard is a secure, fast, and easy to use replacement for IPSec
          that uses modern cryptography and clever networking tricks. It's

which makes powerpc behave the same way as the other architectures.
Ideally wireguard should not need to know about every architecture
specific algorithm that it might use though, and that requires
a different method of enabling those.

     Arnd