linux-kernel - Re: linux-next: manual merge of the scsi-mkp tree with the tip tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250226085435.50a140ab@canb.auug.org.au>
Date: Wed, 26 Feb 2025 08:54:35 +1100
From: Stephen Rothwell <sfr@...b.auug.org.au>
To: Thomas Gleixner <tglx@...utronix.de>
Cc: John Garry <john.g.garry@...cle.com>, "Martin K. Petersen"
 <martin.petersen@...cle.com>, Ingo Molnar <mingo@...hat.com>, "H. Peter
 Anvin" <hpa@...or.com>, Peter Zijlstra <peterz@...radead.org>, Bart Van
 Assche <bvanassche@....org>, Linux Kernel Mailing List
 <linux-kernel@...r.kernel.org>, Linux Next Mailing List
 <linux-next@...r.kernel.org>, Nam Cao <namcao@...utronix.de>
Subject: Re: linux-next: manual merge of the scsi-mkp tree with the tip tree

Hi all,

On Tue, 25 Feb 2025 20:32:28 +0100 Thomas Gleixner <tglx@...utronix.de> wrote:
>
> On Tue, Feb 25 2025 at 09:38, John Garry wrote:
> >
> > static int sdebug_init_cmd_priv(struct Scsi_Host *shost, struct 
> > scsi_cmnd *cmd)
> > {
> > 	struct sdebug_scsi_cmd *sdsc = scsi_cmd_priv(cmd);
> > 	struct sdebug_defer *sd_dp = &sdsc->sd_dp;
> >
> > 	spin_lock_init(&sdsc->lock);
> > 	hrtimer_setup(&sd_dp->hrt, sdebug_q_cmd_hrt_complete, CLOCK_MONOTONIC,
> > 		      HRTIMER_MODE_REL_PINNED);
> > 	sd_dp->hrt.function = sdebug_q_cmd_hrt_complete; ***
> > 	INIT_WORK(&sd_dp->ew.work, sdebug_q_cmd_wq_complete);
> >
> >
> > I guess that setting sd_dp->hrt.function explicitly, at *** above, is 
> > not needed (as hrtimer_setup()) does this.  
> 
> Correct. hrtimer_setup is enough.

Thanks, I have updated my merge resolution.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped