linux-kernel - Re: [PATCH] cifs: Fix the smb1 readv callback to correctly call netfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250225223826.sm4445vrc56mfuwh@pali>
Date: Tue, 25 Feb 2025 23:38:26 +0100
From: Pali Rohár <pali@...nel.org>
To: David Howells <dhowells@...hat.com>
Cc: Steve French <stfrench@...rosoft.com>,
	Jean-Christophe Guillain <jean-christophe@...llain.net>,
	Paulo Alcantara <pc@...guebit.com>,
	Jeff Layton <jlayton@...nel.org>,
	Christian Brauner <brauner@...nel.org>, linux-cifs@...r.kernel.org,
	netfs@...ts.linux.dev, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cifs: Fix the smb1 readv callback to correctly call netfs

On Tuesday 25 February 2025 22:25:00 David Howells wrote:
>     
> Fix cifs_readv_callback() to call netfs_read_subreq_terminated() rather
> than queuing the subrequest work item (which is unset).  Also call the
> I/O progress tracepoint.
> 
> Fixes: e2d46f2ec332 ("netfs: Change the read result collector to only use one work item")
> Reported-by: Jean-Christophe Guillain <jean-christophe@...llain.net>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219793
> Signed-off-by: David Howells <dhowells@...hat.com>
> cc: Steve French <stfrench@...rosoft.com>
> cc: Pali Rohár <pali@...nel.org>
> cc: Paulo Alcantara <pc@...guebit.com>
> cc: Jeff Layton <jlayton@...nel.org>
> cc: linux-cifs@...r.kernel.org
> cc: netfs@...ts.linux.dev
> cc: linux-fsdevel@...r.kernel.org

Thanks! With this change, I cannot reproduce crash anymore.

Tested-by: Pali Rohár <pali@...nel.org>

Steve, could you please include this fix into some queue? This should be
merged into next -rc.

> ---
>  fs/smb/client/cifssmb.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/smb/client/cifssmb.c b/fs/smb/client/cifssmb.c
> index 6a3e287eabfa..bf9acea53ccb 100644
> --- a/fs/smb/client/cifssmb.c
> +++ b/fs/smb/client/cifssmb.c
> @@ -1338,7 +1338,8 @@ cifs_readv_callback(struct mid_q_entry *mid)
>  	rdata->credits.value = 0;
>  	rdata->subreq.error = rdata->result;
>  	rdata->subreq.transferred += rdata->got_bytes;
> -	queue_work(cifsiod_wq, &rdata->subreq.work);
> +	trace_netfs_sreq(&rdata->subreq, netfs_sreq_trace_io_progress);
> +	netfs_read_subreq_terminated(&rdata->subreq);
>  	release_mid(mid);
>  	add_credits(server, &credits, 0);
>  }
>