linux-kernel - Re: [PATCH] drm/xe/regs: remove a duplicate definition for RING_CTL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z75Taxl0rTXGxNfh@lstrano-desk.jf.intel.com>
Date: Tue, 25 Feb 2025 15:34:03 -0800
From: Matthew Brost <matthew.brost@...el.com>
To: Mingcong Bai <jeffbai@...c.io>
CC: <linux-kernel@...r.kernel.org>, Kexy Biscuit <kexybiscuit@...c.io>,
	<stable@...r.kernel.org>, Lucas De Marchi <lucas.demarchi@...el.com>, Thomas
 Hellström <thomas.hellstrom@...ux.intel.com>, Rodrigo Vivi
	<rodrigo.vivi@...el.com>, Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
	Simona Vetter <simona@...ll.ch>, Matt Roper <matthew.d.roper@...el.com>,
	Ashutosh Dixit <ashutosh.dixit@...el.com>, Niranjana Vishwanathapura
	<niranjana.vishwanathapura@...el.com>, Pallavi Mishra
	<pallavi.mishra@...el.com>, José Roberto de Souza
	<jose.souza@...el.com>, Ilia Levi <ilia.levi@...el.com>,
	<intel-xe@...ts.freedesktop.org>, <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH] drm/xe/regs: remove a duplicate definition for
 RING_CTL_SIZE(size)

On Tue, Feb 25, 2025 at 03:31:01PM +0800, Mingcong Bai wrote:
> Commit b79e8fd954c4 ("drm/xe: Remove dependency on intel_engine_regs.h")
> introduced an internal set of engine registers, however, as part of this
> change, it has also introduced two duplicate `define' lines for
> `RING_CTL_SIZE(size)'. This commit was introduced to the tree in v6.8-rc1.
> 
> While this is harmless as the definitions did not change, so no compiler
> warning was observed.
> 
> Drop this line anyway for the sake of correctness.
> 
> Cc: <stable@...r.kernel.org> # v6.8-rc1+
> Fixes: b79e8fd954c4 ("drm/xe: Remove dependency on intel_engine_regs.h")
> Signed-off-by: Mingcong Bai <jeffbai@...c.io>

Reviewed-by: Matthew Brost <matthew.brost@...el.com>

> ---
>  drivers/gpu/drm/xe/regs/xe_engine_regs.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/regs/xe_engine_regs.h b/drivers/gpu/drm/xe/regs/xe_engine_regs.h
> index d86219dedde2a..b732c89816dff 100644
> --- a/drivers/gpu/drm/xe/regs/xe_engine_regs.h
> +++ b/drivers/gpu/drm/xe/regs/xe_engine_regs.h
> @@ -53,7 +53,6 @@
>  
>  #define RING_CTL(base)				XE_REG((base) + 0x3c)
>  #define   RING_CTL_SIZE(size)			((size) - PAGE_SIZE) /* in bytes -> pages */
> -#define   RING_CTL_SIZE(size)			((size) - PAGE_SIZE) /* in bytes -> pages */
>  
>  #define RING_START_UDW(base)			XE_REG((base) + 0x48)
>  
> -- 
> 2.48.1
>