linux-kernel - Re: [PATCH 2/2] dt-bindings: trivial-devices: Document SPI measurement on LWE boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250225-despair-rural-dc10216005f4@spud>
Date: Tue, 25 Feb 2025 23:37:43 +0000
From: Conor Dooley <conor@...nel.org>
To: Lukasz Majewski <lukma@...x.de>
Cc: Rob Herring <robh@...nel.org>,
	Krzysztof@...d.smtp.subspace.kernel.org,
	Kozlowski@...d.smtp.subspace.kernel.org,
	Conor Dooley <conor+dt@...nel.org>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Heiko Stuebner <heiko@...ech.de>, Aradhya Bhatia <a-bhatia1@...com>,
	rafal@...ecki.pl, devicetree@...r.kernel.org,
	Guenter Roeck <linux@...ck-us.net>,
	Noah Wang <noahwang.wang@...look.com>, linux-kernel@...r.kernel.org,
	Peter Yin <peteryin.openbmc@...il.com>,
	Naresh Solanki <naresh.solanki@...ements.com>,
	Alex Vdovydchenko <xzeol@...oo.com>,
	Grant Peltier <grantpeltier93@...il.com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>
Subject: Re: [PATCH 2/2] dt-bindings: trivial-devices: Document SPI
 measurement on LWE boards

On Mon, Feb 24, 2025 at 08:21:31PM +0100, Lukasz Majewski wrote:
> Hi Conor,
> 
> > On Fri, Feb 21, 2025 at 09:56:59PM +0100, Lukasz Majewski wrote:
> > > Hi Conor,
> > >   
> > > > On Fri, Feb 21, 2025 at 04:54:18PM +0100, Lukasz Majewski wrote:  
> > > > > The measurement device on Liebherr's (LWE) boards is used to
> > > > > monitor the overall state of the device. It does have SPI
> > > > > interface to communicate with Linux host via spidev driver.
> > > > > Document the SPI DT binding as trivial SPI device.
> > > > > 
> > > > > Signed-off-by: Lukasz Majewski <lukma@...x.de>
> > > > > ---
> > > > >  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> > > > >  1 file changed, 2 insertions(+)
> > > > > 
> > > > > diff --git
> > > > > a/Documentation/devicetree/bindings/trivial-devices.yaml
> > > > > b/Documentation/devicetree/bindings/trivial-devices.yaml index
> > > > > fadbd3c041c8..5d736a9792c2 100644 ---
> > > > > a/Documentation/devicetree/bindings/trivial-devices.yaml +++
> > > > > b/Documentation/devicetree/bindings/trivial-devices.yaml @@
> > > > > -161,6 +161,8 @@ properties:
> > > > >            - jedec,spd5118
> > > > >              # Linear Technology LTC2488
> > > > >            - lineartechnology,ltc2488
> > > > > +            # Liebherr on-board measurement SPI device
> > > > > +          - lwe,btt    
> >                           ^^
> > Are these two trailing spaces an artefact of the mail?
> > 
> 
> No, there shall not be any.
> 
> > > > 
> > > > How does "btt" translate to what the device actually is? Seems
> > > > kinda random!  
> > > 
> > > Btt is a family of devices (bttc, btt3, xea) - to control heavy duty
> > > machines.
> > > 
> > > That was the original codename - conceived probably 30+ years ago.  
> > 
> > If there's 3 different devices, how come there aren't 3 compatibles, 1
> > for each?
> 
> There are devices from a single "family" of them, but different.
> 
> They are using similar approach for spidev devices connected.

"Similar" means different, and therefore you need to differentiate
between devices. In turn that means they should have distinct
compatibles.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)