linux-kernel - Re: [PATCH v3] scsi: hpsa: Remove deprecated and unnecessary strncpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <174044345120.2973737.13335141842683533992.b4-ty@oracle.com>
Date: Mon, 24 Feb 2025 19:32:51 -0500
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Don Brace <don.brace@...rochip.com>,
        "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
        Thorsten Blum <thorsten.blum@...ux.dev>
Cc: "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-hardening@...r.kernel.org, Kees Cook <kees@...nel.org>,
        David Laight <david.laight.linux@...il.com>,
        Bart Van Assche <bvanassche@....org>, storagedev@...rochip.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] scsi: hpsa: Remove deprecated and unnecessary strncpy()

On Fri, 14 Feb 2025 12:43:02 +0100, Thorsten Blum wrote:

> While replacing strncpy() with strscpy(), Bart Van Assche pointed out
> that the code occurs inside sysfs write callbacks, which already uses
> NUL-terminated strings. This allows the string to be passed directly to
> sscanf() without requiring a temporary copy.
> 
> Remove the deprecated and unnecessary strncpy() and the corresponding
> local variables, and pass the buffer buf directly to sscanf().
> 
> [...]

Applied to 6.15/scsi-queue, thanks!

[1/1] scsi: hpsa: Remove deprecated and unnecessary strncpy()
      https://git.kernel.org/mkp/scsi/c/d69ddae194ca

-- 
Martin K. Petersen	Oracle Linux Engineering