linux-kernel - Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca34309a-f2b2-4082-92df-86a775952348@suse.de>
Date: Tue, 25 Feb 2025 08:56:54 +0100
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Aditya Garg <gargaditya08@...e.com>,
 "maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
 "mripard@...nel.org" <mripard@...nel.org>,
 "airlied@...il.com" <airlied@...il.com>, "simona@...ll.ch"
 <simona@...ll.ch>,
 "andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>
Cc: Kerem Karabay <kekrby@...il.com>, Atharva Tiwari <evepolonium@...il.com>,
 Aun-Ali Zaidi <admin@...eit.net>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86
 Macs

Hi

Am 24.02.25 um 17:58 schrieb Aditya Garg:
[...]
>>
>> +config DRM_APPLETBDRM
>> +    tristate "DRM support for Apple Touch Bars"
>> +    depends on DRM && USB && MMU
>> +    select DRM_GEM_SHMEM_HELPER
>> +    select DRM_KMS_HELPER
>> +    select HID_APPLETB_BL
> Btw I have a doubt regarding this dependency. While hid-appletb-bl has made into the linux-next tree, it has still not been merged into Linus' tree, and neither the drm tree I assume. It potentially could cause issues?

Yes. We cannot merge this driver until we have this symbol in our tree. 
But that will happen sooner or later.

More problematic is that your driver selects HID_APPLETB_BL. From what 
I've seen, this symbol is user configurable, so the driver shouldn't 
select it. You need to use 'depends on' instead of 'select' here.

Best regards
Thomas

>
>> +    select HID_MULTITOUCH
>> +    help
>> +      Say Y here if you want support for the display of Touch Bars on x86
>> +      MacBook Pros.
>> +
>> +      To compile this driver as a module, choose M here: the
>> +      module will be called appletbdrm.
>> +

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)